src/arm/debug-arm.cc - Issue 15085026: ARM: Smi refactoring and improvements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/debug-arm.cc

Issue 15085026: ARM: Smi refactoring and improvements. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/debug-arm.cc

diff --git a/src/arm/debug-arm.cc b/src/arm/debug-arm.cc

index 6bfaf414c332d4fa2857e751a12d120ba1bfbd57..2f0a7c4e54ef5a18c323cefb36dce28d8dd8940d 100644

--- a/src/arm/debug-arm.cc

+++ b/src/arm/debug-arm.cc

@@ -132,7 +132,7 @@ static void Generate_DebugBreakCallHelper(MacroAssembler* masm,

__ tst(reg, Operand(0xc0000000));

__ Assert(eq, "Unable to encode value as smi");

}

- __ mov(reg, Operand(reg, LSL, kSmiTagSize));

+ __ SmiTag(reg);

}

__ stm(db_w, sp, object_regs | non_object_regs);

@@ -154,7 +154,7 @@ static void Generate_DebugBreakCallHelper(MacroAssembler* masm,

int r = JSCallerSavedCode(i);

if ((non_object_regs & (1 << r)) != 0) {

- __ mov(reg, Operand(reg, LSR, kSmiTagSize));

+ __ SmiUntag(reg);

}

if (FLAG_debug_code &&

(((object_regs |non_object_regs) & (1 << r)) == 0)) {