Issue 15085019: [MIPS] Fix correct toolchain_dir for MIPS/Android builds

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15085019: [MIPS] Fix correct toolchain_dir for MIPS/Android builds (Closed)

Created:
7 years, 7 months ago by petarj

Modified:
7 years, 7 months ago

Reviewers:
cjhopman, Yaron, Torne

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[MIPS] Fix correct toolchain_dir for MIPS/Android builds After recent change in android_tools to update ndk, the scripts can reuse android_host_arch variable for MIPS too. This is important, as the release now contains 64-bit host toolchain set. BUG=130022 TEST=build content_shell_apk Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199492

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	build/android/envsetup_functions.sh	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	build/common.gypi	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/petarj@mips.com/15085019/1

7 years, 7 months ago (2013-05-10 14:24:16 UTC) #3

Message was sent while issue was closed.

Change committed as 199492

Expand Messages | Collapse Messages