Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15085010: install-build-deps: Non-english locale + Ubuntu 13.04 (Closed)

Created:
7 years, 7 months ago by Vanuan
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

install-build-deps: Non-english locale + Ubuntu 13.04 Added support for installing dependencies on non-english Ubuntu 13.04 BUG=239505 TEST=Tested manually Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199448

Patch Set 1 : Non-english locale + Ubuntu 13.04 #

Total comments: 1

Patch Set 2 : Fix AUTHORS #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M ui/base/x/x11_util.cc View 1 2 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
commit-bot: I haz the power
No reviewers yet.
7 years, 7 months ago (2013-05-09 18:30:08 UTC) #1
Vanuan
It's my first contribution to Chromium. Sorry if I did something wrong.
7 years, 7 months ago (2013-05-09 18:59:03 UTC) #2
Vanuan
https://codereview.chromium.org/15085010/diff/2001/build/install-build-deps.sh File build/install-build-deps.sh (right): https://codereview.chromium.org/15085010/diff/2001/build/install-build-deps.sh#newcode260 build/install-build-deps.sh:260: if new_list="$(yes n | LANGUAGE=en LANG=C $new_list_cmd)"; then Explanation: ...
7 years, 7 months ago (2013-05-09 19:45:39 UTC) #3
Paweł Hajdan Jr.
LGTM
7 years, 7 months ago (2013-05-09 20:03:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Vanuan@gmail.com/15085010/4002
7 years, 7 months ago (2013-05-09 20:03:58 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=146425
7 years, 7 months ago (2013-05-10 00:36:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Vanuan@gmail.com/15085010/4002
7 years, 7 months ago (2013-05-10 01:52:36 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=146576
7 years, 7 months ago (2013-05-10 04:08:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/Vanuan@gmail.com/15085010/4002
7 years, 7 months ago (2013-05-10 07:49:45 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-05-10 10:10:04 UTC) #10
Message was sent while issue was closed. 
Change committed as 199448

Powered by Google App Engine
This is Rietveld 408576698