Issue 15085006: Inline Uint32x4 operations

Issue 15085006: Inline Uint32x4 operations (Closed)

Created:
7 years, 7 months ago by Cutch

Modified:
7 years, 7 months ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Inline Uint32x4 operations R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=22649

Patch Set 3 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1295 lines, -73 lines)			Patch
M	runtime/vm/flow_graph_optimizer.h	View	1 2	2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2	17 chunks	+178 lines, -13 lines	0 comments	Download
M	runtime/vm/flow_graph_type_propagator.cc	View	1 2	1 chunk	+29 lines, -0 lines	0 comments	Download
M	runtime/vm/il_printer.cc	View	1 2	1 chunk	+51 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2	17 chunks	+355 lines, -26 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2	1 chunk	+65 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2	4 chunks	+265 lines, -17 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2	1 chunk	+66 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2	4 chunks	+282 lines, -17 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

Cutch

./tools/test.py -m all -a all Test configurations: none_vm_debug_ia32 none_vm_release_ia32 none_vm_debug_x64 none_vm_release_x64 none_vm_debug_simarm none_vm_release_simarm none_vm_debug_simmips none_vm_release_simmips ...

7 years, 7 months ago (2013-05-09 16:46:00 UTC) #2

srdjan

LGTM with comments https://codereview.chromium.org/15085006/diff/11/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/15085006/diff/11/runtime/vm/flow_graph_optimizer.cc#newcode1520 runtime/vm/flow_graph_optimizer.cc:1520: if (!ic_data.HasReceiverClassId(kUint32x4Cid) || Bad indent (3 ...

7 years, 7 months ago (2013-05-10 18:36:57 UTC) #3

Florian Schneider

https://codereview.chromium.org/15085006/diff/11/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/15085006/diff/11/runtime/vm/flow_graph_optimizer.cc#newcode1524 runtime/vm/flow_graph_optimizer.cc:1524: return false; dbc: Shouldn't this return a Uint32x4GetFlagInstr here?

7 years, 7 months ago (2013-05-13 08:46:20 UTC) #4

Cutch

https://codereview.chromium.org/15085006/diff/11/runtime/vm/flow_graph_optimizer.cc File runtime/vm/flow_graph_optimizer.cc (right): https://codereview.chromium.org/15085006/diff/11/runtime/vm/flow_graph_optimizer.cc#newcode1520 runtime/vm/flow_graph_optimizer.cc:1520: if (!ic_data.HasReceiverClassId(kUint32x4Cid) || On 2013/05/10 18:36:58, srdjan wrote: > ...

7 years, 7 months ago (2013-05-13 19:40:23 UTC) #5

Cutch

Test configurations: none_vm_debug_ia32 none_vm_release_ia32 none_vm_debug_x64 none_vm_release_x64 none_vm_debug_simarm none_vm_release_simarm none_vm_debug_simmips none_vm_release_simmips [10:18 | 100% | +29297 ...

7 years, 7 months ago (2013-05-13 20:08:34 UTC) #6

Cutch

7 years, 7 months ago (2013-05-13 20:22:14 UTC) #7

Message was sent while issue was closed.

Committed patchset #3 manually as r22649 (presubmit successful).

Expand Messages | Collapse Messages