Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1888)

Unified Diff: ui/gfx/icon_util.cc

Issue 15080002: Use important_file_writer to write .ico files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/gfx/icon_util.cc
diff --git a/ui/gfx/icon_util.cc b/ui/gfx/icon_util.cc
index 37ab0d59f53b16e2a702038c541697817ce1ff00..cc6cc909e5775c5979b9a83d9ab50efe37929c7c 100644
--- a/ui/gfx/icon_util.cc
+++ b/ui/gfx/icon_util.cc
@@ -5,6 +5,7 @@
#include "ui/gfx/icon_util.h"
#include "base/file_util.h"
+#include "base/files/important_file_writer.h"
#include "base/logging.h"
#include "base/memory/scoped_ptr.h"
#include "base/win/resource_util.h"
@@ -470,13 +471,6 @@ bool IconUtil::CreateIconFileFromImageFamily(
// Including PNG image, if any.
size_t image_count = bitmap_count + (png_bytes.get() ? 1 : 0);
- // Now that basic checks are done, we can create the file.
- base::win::ScopedHandle icon_file(::CreateFile(icon_path.value().c_str(),
- GENERIC_WRITE, 0, NULL, CREATE_ALWAYS, FILE_ATTRIBUTE_NORMAL, NULL));
-
- if (!icon_file.IsValid())
- return false;
-
// Computing the total size of the buffer we need in order to store the
// images in the desired icon format.
size_t buffer_size = ComputeIconFileBufferSize(bitmaps);
@@ -521,22 +515,8 @@ bool IconUtil::CreateIconFileFromImageFamily(
DCHECK_EQ(offset, buffer_size);
- // Finally, write the data to the file.
- DWORD bytes_written;
- bool delete_file = false;
- if (!WriteFile(icon_file.Get(), &buffer[0], buffer_size, &bytes_written,
- NULL) ||
- bytes_written != buffer_size) {
- delete_file = true;
- }
-
- ::CloseHandle(icon_file.Take());
- if (delete_file) {
- bool success = file_util::Delete(icon_path, false);
- DCHECK(success);
- }
-
- return !delete_file;
+ std::string data(buffer.begin(), buffer.end());
+ return base::ImportantFileWriter::WriteFileAtomically(icon_path, data);
}
bool IconUtil::PixelsHaveAlpha(const uint32* pixels, size_t num_pixels) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698