Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 15080002: Use important_file_writer to write .ico files (Closed)

Created:
7 years, 7 months ago by calamity
Modified:
7 years, 7 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Use important_file_writer to write .ico files This change should make the writing of icon files more robust as they won't write corrupt icon files. BUG=167984 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199667

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -23 lines) Patch
M ui/gfx/icon_util.cc View 1 3 chunks +3 lines, -23 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
calamity
7 years, 7 months ago (2013-05-09 01:38:12 UTC) #1
Alexei Svitkine (slow)
LGTM! Please set the BUG= to the tracking bug you're using for the pinned profile ...
7 years, 7 months ago (2013-05-09 15:36:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/15080002/1
7 years, 7 months ago (2013-05-13 00:00:15 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-13 00:42:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/15080002/19001
7 years, 7 months ago (2013-05-13 03:12:19 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-13 06:26:26 UTC) #6
Message was sent while issue was closed.
Change committed as 199667

Powered by Google App Engine
This is Rietveld 408576698