Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Unified Diff: base/files/file_path_unittest.cc

Issue 15078003: Cleanup: Remove unneeded base/file_util.h includes in base. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/file_version_info_unittest.cc ('k') | base/files/file_path_watcher_kqueue.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/files/file_path_unittest.cc
===================================================================
--- base/files/file_path_unittest.cc (revision 199852)
+++ base/files/file_path_unittest.cc (working copy)
@@ -3,7 +3,6 @@
// found in the LICENSE file.
#include "base/basictypes.h"
-#include "base/file_util.h"
#include "base/files/file_path.h"
#include "base/utf_string_conversions.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -1122,32 +1121,32 @@
TEST_F(FilePathTest, ConstructWithNUL) {
// Assert FPS() works.
- ASSERT_TRUE(FPS("a\0b").length() == 3);
+ ASSERT_EQ(3U, FPS("a\0b").length());
// Test constructor strips '\0'
FilePath path(FPS("a\0b"));
- EXPECT_TRUE(path.value().length() == 1);
- EXPECT_EQ(path.value(), FPL("a"));
+ EXPECT_EQ(1U, path.value().length());
+ EXPECT_EQ(FPL("a"), path.value());
}
TEST_F(FilePathTest, AppendWithNUL) {
// Assert FPS() works.
- ASSERT_TRUE(FPS("b\0b").length() == 3);
+ ASSERT_EQ(3U, FPS("b\0b").length());
// Test Append() strips '\0'
FilePath path(FPL("a"));
path = path.Append(FPS("b\0b"));
- EXPECT_TRUE(path.value().length() == 3);
+ EXPECT_EQ(3U, path.value().length());
#if defined(FILE_PATH_USES_WIN_SEPARATORS)
- EXPECT_EQ(path.value(), FPL("a\\b"));
+ EXPECT_EQ(FPL("a\\b"), path.value());
#else
- EXPECT_EQ(path.value(), FPL("a/b"));
+ EXPECT_EQ(FPL("a/b"), path.value());
#endif
}
TEST_F(FilePathTest, ReferencesParentWithNUL) {
// Assert FPS() works.
- ASSERT_TRUE(FPS("..\0").length() == 3);
+ ASSERT_EQ(3U, FPS("..\0").length());
// Test ReferencesParent() doesn't break with "..\0"
FilePath path(FPS("..\0"));
« no previous file with comments | « base/file_version_info_unittest.cc ('k') | base/files/file_path_watcher_kqueue.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698