Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 15078003: Cleanup: Remove unneeded base/file_util.h includes in base. (Closed)

Created:
7 years, 7 months ago by Lei Zhang
Modified:
7 years, 7 months ago
CC:
chromium-reviews, sail+watch_chromium.org, erikwright+watch_chromium.org, gavinp+memory_chromium.org, jshin+watch_chromium.org
Visibility:
Public.

Description

Cleanup: Remove unneeded base/file_util.h includes in base. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199960

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -40 lines) Patch
M base/base_paths_win.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M base/file_version_info_unittest.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M base/files/file_path_unittest.cc View 1 2 chunks +8 lines, -9 lines 0 comments Download
M base/files/file_path_watcher_kqueue.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M base/files/file_util_proxy.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/files/file_util_proxy_unittest.cc View 1 2 chunks +12 lines, -11 lines 0 comments Download
M base/i18n/icu_util.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/memory/singleton_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M base/process_util_freebsd.cc View 1 4 chunks +3 lines, -4 lines 0 comments Download
M base/process_util_openbsd.cc View 1 3 chunks +0 lines, -3 lines 0 comments Download
M base/sync_socket_nacl.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/media_galleries/fileapi/native_media_file_util_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/nacl_host/nacl_browser.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 2 chunks +1 line, -1 line 0 comments Download
M webkit/fileapi/isolated_file_util.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/fileapi/local_file_system_operation_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/fileapi/local_file_system_quota_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/fileapi/local_file_util.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/fileapi/local_file_util_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/fileapi/native_file_util_unittest.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M webkit/fileapi/sandbox_mount_point_provider.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M webkit/plugins/ppapi/quota_file_io_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Lei Zhang
includes lint fixes as well.
7 years, 7 months ago (2013-05-13 23:33:42 UTC) #1
darin (slow to review)
rubber stamp LGTM
7 years, 7 months ago (2013-05-13 23:38:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/15078003/36002
7 years, 7 months ago (2013-05-13 23:44:13 UTC) #3
commit-bot: I haz the power
Failed to apply patch for chrome/browser/media_galleries/fileapi/native_media_file_util.cc: While running patch -p0 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-13 23:44:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/15078003/52001
7 years, 7 months ago (2013-05-13 23:56:59 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-14 10:12:58 UTC) #6
Message was sent while issue was closed.
Change committed as 199960

Powered by Google App Engine
This is Rietveld 408576698