Basic device support for ninja iOS builds.

Basic device support for ninja iOS builds.

Set ARCHS for device iOS builds when GYP_DEFINES sets host_arch=ia32 target_arch=armv7.  Device builds still won't be signed, so they can't bee installed on devices yet.

BUG=236517
TEST=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=212442

[Ami GONE FROM CHROMIUM, 2013-07-12 20:30:48]

This CL lets me get much farther with ios device builds (e.g. libvpx and many of
libjingle's deps now build for ios device).  Is there any reason for it not to
land as-is?

[Ami GONE FROM CHROMIUM, 2013-07-12 20:36:42]

(FWIW the change LGTM assuming the CL description is trimmed back to what it
does ATM)

[justincohen, 2013-07-18 00:23:01]

PTAL!

[Nico, 2013-07-18 00:27:21]

cl description should say "ninja" somewhere

[Nico, 2013-07-18 00:29:08]

https://codereview.chromium.org/15075006/diff/4001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/15075006/diff/4001/build/common.gypi#newcode4164
build/common.gypi:4164: 'ARCHS': ['i386'],
Don't you want to use 64 bit host binaries?

https://codereview.chromium.org/15075006/diff/4001/build/common.gypi#newcode4178
build/common.gypi:4178: 'xcode_settings': { 'ARCHS': [ 'i386' ] },
is this block needed?

[justincohen, 2013-07-18 02:04:09]

PTAL!

https://codereview.chromium.org/15075006/diff/4001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/15075006/diff/4001/build/common.gypi#newcode4164
build/common.gypi:4164: 'ARCHS': ['i386'],
On 2013/07/18 00:29:08, Nico wrote:
> Don't you want to use 64 bit host binaries?

Done.

https://codereview.chromium.org/15075006/diff/4001/build/common.gypi#newcode4178
build/common.gypi:4178: 'xcode_settings': { 'ARCHS': [ 'i386' ] },
Yes, we still need to set the target to i386 for simulator builds.

On 2013/07/18 00:29:08, Nico wrote:
> is this block needed?

[Nico, 2013-07-18 04:23:56]

lgtm

https://codereview.chromium.org/15075006/diff/10001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/15075006/diff/10001/build/common.gypi#newcode...
build/common.gypi:4178: 'xcode_settings': { 'ARCHS': [ 'i386' ] },
Simulator can't be 64 bit? I thought apple was trying to get rid of 32 bit apps.

[justincohen, 2013-07-18 12:05:59]

https://codereview.chromium.org/15075006/diff/10001/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/15075006/diff/10001/build/common.gypi#newcode...
build/common.gypi:4178: 'xcode_settings': { 'ARCHS': [ 'i386' ] },
Nope, looks like it's not supported.


On 2013/07/18 04:23:57, Nico wrote:
> Simulator can't be 64 bit? I thought apple was trying to get rid of 32 bit
apps.

[lliabraa, 2013-07-18 15:50:40]

LGTM

[commit-bot: I haz the power, 2013-07-18 16:36:47]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/justincohen@google.com/15075006/15001

[commit-bot: I haz the power, 2013-07-18 21:49:40]

Change committed as 212442