Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Unified Diff: net/quic/quic_spdy_decompressor.cc

Issue 15074007: Land Recent QUIC changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix for windows Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_spdy_decompressor.h ('k') | net/quic/quic_spdy_decompressor_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_spdy_decompressor.cc
diff --git a/net/quic/quic_spdy_decompressor.cc b/net/quic/quic_spdy_decompressor.cc
index f96e8466bff775975db35bb64371cc288d27818d..0d589377ce017486c3dcf50aa2fa00bf0330414d 100644
--- a/net/quic/quic_spdy_decompressor.cc
+++ b/net/quic/quic_spdy_decompressor.cc
@@ -75,7 +75,7 @@ bool SpdyFramerVisitor::OnControlFrameHeaderData(SpdyStreamId stream_id,
}
QuicSpdyDecompressor::QuicSpdyDecompressor()
- : spdy_framer_(3),
+ : spdy_framer_(kSpdyVersion3),
spdy_visitor_(new SpdyFramerVisitor(NULL)),
current_header_id_(1),
has_current_compressed_size_(false),
@@ -116,9 +116,11 @@ size_t QuicSpdyDecompressor::DecompressData(StringPiece data,
min(current_compressed_size_ - compressed_bytes_consumed_,
static_cast<uint32>(data.length()));
if (bytes_to_consume > 0) {
- bool success = spdy_framer_.IncrementallyDecompressControlFrameHeaderData(
- current_header_id_, data.data(), bytes_to_consume);
- DCHECK(success);
+ if (!spdy_framer_.IncrementallyDecompressControlFrameHeaderData(
+ current_header_id_, data.data(), bytes_to_consume)) {
+ visitor->OnDecompressionError();
+ return bytes_consumed;
+ }
compressed_bytes_consumed_ += bytes_to_consume;
bytes_consumed += bytes_to_consume;
}
« no previous file with comments | « net/quic/quic_spdy_decompressor.h ('k') | net/quic/quic_spdy_decompressor_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698