Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Unified Diff: net/quic/crypto/common_cert_set.h

Issue 15074007: Land Recent QUIC changes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix for windows Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/crypto/cert_compressor_test.cc ('k') | net/quic/crypto/common_cert_set.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/crypto/common_cert_set.h
diff --git a/net/quic/crypto/common_cert_set.h b/net/quic/crypto/common_cert_set.h
index 69729263db795cdeba5a18af1be828ee13e0560d..4f5d33038e62b4796f1117b0fa81f752210be389 100644
--- a/net/quic/crypto/common_cert_set.h
+++ b/net/quic/crypto/common_cert_set.h
@@ -20,24 +20,26 @@ class NET_EXPORT_PRIVATE CommonCertSets {
virtual ~CommonCertSets();
// GetCommonHashes returns a StringPiece containing the hashes of common sets
- // supported by this object.
+ // supported by this object. The 64-bit hashes are concatenated in the
+ // StringPiece.
virtual base::StringPiece GetCommonHashes() const = 0;
- // GetCert returns a specific certificate in the common set identified by
- // |hash|. If no such certificate is known, an empty StringPiece is returned.
+ // GetCert returns a specific certificate (at index |index|) in the common
+ // set identified by |hash|. If no such certificate is known, an empty
+ // StringPiece is returned.
virtual base::StringPiece GetCert(uint64 hash, uint32 index) const = 0;
// MatchCert tries to find |cert| in one of the common certificate sets
- // identified by |common_set_hashes|. On success it puts the hash in
- // |out_hash|, the index in the set in |out_index| and returns true. Otherwise
- // it returns false.
+ // identified by |common_set_hashes|. On success it puts the hash of the
+ // set in |out_hash|, the index of |cert| in the set in |out_index| and
+ // returns true. Otherwise it returns false.
virtual bool MatchCert(base::StringPiece cert,
base::StringPiece common_set_hashes,
uint64* out_hash,
uint32* out_index) const = 0;
};
-// CommonCertSetsQUIC implements the CommonCertSet interface using the default
+// CommonCertSetsQUIC implements the CommonCertSets interface using the default
// certificate sets.
class NET_EXPORT_PRIVATE CommonCertSetsQUIC : public CommonCertSets {
public:
« no previous file with comments | « net/quic/crypto/cert_compressor_test.cc ('k') | net/quic/crypto/common_cert_set.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698