Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Issue 15074007: Land Recent QUIC changes. (Closed)

Created:
7 years, 7 months ago by ramant (doing other things)
Modified:
7 years, 7 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Land Recent QUIC changes. Stop versioning non crypto parameters by SCFG. This enables the server to send different values for these parameters for same SCFG. As a consequence the server sends the negotiated (authoritative) values of these parameters in SHLO. Merge internal change: 45655201 QUIC: make several magic values configurable. This is half a change. The other half needs to alter server and so I'll put it in a different CL. This makes four magic values from the server handshake into parameters of the server config. A future CL will be able to have the server set them from it's SSL config protobuf. Merge internal change: 45622443 QUIC: don't request a proof if the client doesn't have a ProofVerifier. In order to support cert-less operation, this change alters the client to not request a proof from the server if it doesn't have a ProofVerifier configured. Without a ProofVerifier, the client will simply do opportunistic encryption. Merge internal change: 45614800 * Stop processing if the current packet closed the connection. * Close the connection if invalid RST packet received (consistent with current behavior) -- UDP provides simple CRC. Merge internal change: 45612040 Don't call ConnectionClose on ConnectionCloseFrame if visitor asked to stop after processing ack frame. Merge internal change: 45606025 Don't further process revived packet if visitor refuses the packet header. Merge internal change: 45530388 Fix coding style nits. Use "*sets" instead of "set" for arguments or variables of the CommonCertSets type. Merge internal change: 45523282 Added enum for write packet error. Handling failed writes due to errors other than EAGAIN/EWOULDBLOCK I don't know if this happens for us but might as well handle it. Merge internal change: 45522400 Tear down the connection when there is a decompression error. Merge internal change: 45521857 Bugfix infinite wait Merge internal change: 45509285 Replaced number 3 with kSpdyVersion3. Will work akalin to define and use SpdyMajorVersion enum and use it everywhere. This is a partial merge of internal change: 45485205 Removing an obselete TODO Merge internal change: 45471987 Move QuicConfig out of QuicCryptoStream. The motivation behind this change is to be able to select different values for QuicConfig depending upon SNI (after we receive CHLO). Merge internal change: 45434264 Limiting the number of FEC groups to 2 Merge internal change: 45425759 Closing connection on out of bounds packet. Merge internal change: 45413532 Miscellaneous cleanup: add 'const', remove unneeded headers, and make random minor fixes. Document the CommonCertSets methods better. Merge internal change: 45380570 Move FindMutualTag from CryptoUtils to QuicUtils. We will also use this in version negotiation Merge internal change: 45337156 Replacing CHECK-fails on address migration with graceful shutdown. Added GetAddressFamily utility method. Added check for IPV4 in WritePacket method QuicSocketUtils to copy the IPV4 self_address. Merge internal change: 45306947 QUIC - Negotiate max open streams. Added QuicClientSessionPeer to access QuicConfig in QuicClientSession. Merge internal change: 45233402 Allow retransmitting packets that are retransmissions when we get trucated acks. Merge internal change: 45233252 Reduce connection timeout till crypto handshake is finished to 1min. Merge internal change: 45232483 R=rch@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200519

Patch Set 1 #

Patch Set 2 : Merging with TOT #

Patch Set 3 : Fix android build #

Patch Set 4 : fix for windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1761 lines, -585 lines) Patch
M net/base/ip_endpoint.cc View 1 chunk +1 line, -9 lines 0 comments Download
M net/base/net_util.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/base/net_util.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M net/base/net_util_unittest.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M net/net.gyp View 1 3 chunks +7 lines, -0 lines 0 comments Download
M net/quic/congestion_control/hybrid_slow_start.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/congestion_control/tcp_cubic_sender.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/crypto/cert_compressor.h View 1 chunk +9 lines, -9 lines 0 comments Download
M net/quic/crypto/cert_compressor.cc View 8 chunks +12 lines, -12 lines 0 comments Download
M net/quic/crypto/cert_compressor_test.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M net/quic/crypto/common_cert_set.h View 1 chunk +9 lines, -7 lines 0 comments Download
M net/quic/crypto/common_cert_set.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M net/quic/crypto/common_cert_set_test.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/quic/crypto/crypto_handshake.h View 3 chunks +4 lines, -5 lines 0 comments Download
M net/quic/crypto/crypto_handshake.cc View 8 chunks +19 lines, -46 lines 0 comments Download
M net/quic/crypto/crypto_handshake_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/crypto/crypto_protocol.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/crypto/crypto_server_config.h View 5 chunks +35 lines, -9 lines 0 comments Download
M net/quic/crypto/crypto_server_config.cc View 9 chunks +42 lines, -22 lines 0 comments Download
M net/quic/crypto/crypto_utils.h View 1 chunk +0 lines, -20 lines 0 comments Download
M net/quic/crypto/crypto_utils.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M net/quic/quic_client_session.h View 3 chunks +6 lines, -3 lines 0 comments Download
M net/quic/quic_client_session.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M net/quic/quic_client_session_test.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M net/quic/quic_config.h View 1 2 3 2 chunks +144 lines, -26 lines 0 comments Download
M net/quic/quic_config.cc View 1 2 3 1 chunk +288 lines, -74 lines 0 comments Download
A net/quic/quic_config_test.cc View 1 chunk +167 lines, -0 lines 0 comments Download
M net/quic/quic_connection.h View 1 2 3 4 chunks +8 lines, -5 lines 0 comments Download
M net/quic/quic_connection.cc View 1 2 3 19 chunks +91 lines, -53 lines 0 comments Download
M net/quic/quic_connection_helper_test.cc View 5 chunks +12 lines, -10 lines 0 comments Download
M net/quic/quic_connection_test.cc View 6 chunks +101 lines, -8 lines 0 comments Download
M net/quic/quic_crypto_client_stream.h View 3 chunks +0 lines, -3 lines 0 comments Download
M net/quic/quic_crypto_client_stream.cc View 1 4 chunks +7 lines, -11 lines 0 comments Download
M net/quic/quic_crypto_client_stream_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_crypto_client_stream_test.cc View 4 chunks +11 lines, -8 lines 0 comments Download
M net/quic/quic_crypto_server_stream.h View 3 chunks +1 line, -6 lines 0 comments Download
M net/quic/quic_crypto_server_stream.cc View 2 chunks +4 lines, -5 lines 0 comments Download
M net/quic/quic_crypto_server_stream_test.cc View 8 chunks +38 lines, -19 lines 0 comments Download
M net/quic/quic_crypto_stream.h View 2 chunks +0 lines, -2 lines 0 comments Download
M net/quic/quic_crypto_stream.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M net/quic/quic_framer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/quic/quic_framer.cc View 6 chunks +22 lines, -11 lines 0 comments Download
M net/quic/quic_framer_test.cc View 7 chunks +73 lines, -6 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/quic/quic_protocol.h View 4 chunks +16 lines, -3 lines 0 comments Download
M net/quic/quic_reliable_client_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/quic_session.h View 4 chunks +12 lines, -2 lines 0 comments Download
M net/quic/quic_session.cc View 2 chunks +12 lines, -3 lines 0 comments Download
M net/quic/quic_session_test.cc View 6 chunks +31 lines, -2 lines 0 comments Download
M net/quic/quic_spdy_compressor.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/quic/quic_spdy_decompressor.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/quic_spdy_decompressor.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M net/quic/quic_spdy_decompressor_test.cc View 1 chunk +16 lines, -0 lines 0 comments Download
M net/quic/quic_stream_factory.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M net/quic/quic_utils.h View 3 chunks +26 lines, -0 lines 0 comments Download
M net/quic/quic_utils.cc View 1 2 5 chunks +82 lines, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/reliable_quic_stream.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M net/quic/test_tools/crypto_test_utils.h View 1 chunk +12 lines, -1 line 0 comments Download
M net/quic/test_tools/crypto_test_utils.cc View 5 chunks +18 lines, -19 lines 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream_factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M net/quic/test_tools/mock_crypto_client_stream_factory.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A net/quic/test_tools/quic_client_session_peer.h View 1 chunk +29 lines, -0 lines 0 comments Download
A net/quic/test_tools/quic_client_session_peer.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.h View 3 chunks +13 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_connection_peer.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M net/quic/test_tools/quic_session_peer.h View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_session_peer.cc View 1 chunk +7 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.h View 2 chunks +6 lines, -1 line 0 comments Download
M net/quic/test_tools/quic_test_utils.cc View 3 chunks +9 lines, -3 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 3 13 chunks +70 lines, -15 lines 0 comments Download
M net/tools/quic/quic_client.h View 2 chunks +6 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M net/tools/quic/quic_client_session.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/quic_client_session_test.cc View 2 chunks +16 lines, -15 lines 0 comments Download
M net/tools/quic/quic_epoll_connection_helper.h View 2 chunks +5 lines, -0 lines 0 comments Download
M net/tools/quic/quic_epoll_connection_helper_test.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M net/tools/quic/quic_reliable_client_stream.h View 2 chunks +0 lines, -3 lines 0 comments Download
M net/tools/quic/quic_reliable_client_stream_test.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M net/tools/quic/quic_server.cc View 1 chunk +1 line, -8 lines 0 comments Download
M net/tools/quic/quic_server_session.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M net/tools/quic/quic_socket_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
A net/tools/quic/test_tools/quic_client_peer.h View 1 chunk +25 lines, -0 lines 0 comments Download
A net/tools/quic/test_tools/quic_client_peer.cc View 1 chunk +27 lines, -0 lines 0 comments Download
A net/tools/quic/test_tools/quic_epoll_connection_helper_peer.h View 1 chunk +31 lines, -0 lines 0 comments Download
A net/tools/quic/test_tools/quic_epoll_connection_helper_peer.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.h View 1 chunk +6 lines, -1 line 0 comments Download
M net/tools/quic/test_tools/quic_test_utils.cc View 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
ramant (doing other things)
7 years, 7 months ago (2013-05-15 21:13:48 UTC) #1
Ryan Hamilton
lgtm since I've reviewed all the constituent CLs.
7 years, 7 months ago (2013-05-15 21:20:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/15074007/4001
7 years, 7 months ago (2013-05-15 21:32:02 UTC) #3
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-15 22:09:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/15074007/45001
7 years, 7 months ago (2013-05-16 01:35:04 UTC) #5
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 7 months ago (2013-05-16 02:32:20 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/15074007/61001
7 years, 7 months ago (2013-05-16 06:53:02 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-16 12:52:43 UTC) #8
Message was sent while issue was closed.
Change committed as 200519

Powered by Google App Engine
This is Rietveld 408576698