Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: ppapi/proxy/nacl_message_scanner.cc

Issue 150713003: Create IPC channel to communicate with the renderer in NaClListener::OnStart(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ppapi/proxy/DEPS ('k') | ppapi/proxy/plugin_main_nacl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ppapi/proxy/nacl_message_scanner.cc
diff --git a/ppapi/proxy/nacl_message_scanner.cc b/ppapi/proxy/nacl_message_scanner.cc
index 44324c3a63623146242e806b1dcd6d277e68a083..6fb98f5f1c6037117963a3ba9a20d34c7d210b61 100644
--- a/ppapi/proxy/nacl_message_scanner.cc
+++ b/ppapi/proxy/nacl_message_scanner.cc
@@ -289,11 +289,6 @@ NaClMessageScanner::~NaClMessageScanner() {
// message body, rather than passed in a separate FileDescriptorSet. Therefore,
// on Windows, any message containing handles must be rewritten in the POSIX
// format before we can send it to the NaCl plugin.
-//
-// On POSIX and Windows we have to rewrite PpapiMsg_CreateNaClChannel messages.
-// These contain a handle with an invalid (place holder) descriptor. We need to
-// locate this handle so it can be replaced with a valid one when the channel is
-// created.
bool NaClMessageScanner::ScanMessage(
const IPC::Message& msg,
std::vector<SerializedHandle>* handles,
@@ -307,7 +302,7 @@ bool NaClMessageScanner::ScanMessage(
#if defined(OS_WIN)
true;
#else
- (msg.type() == PpapiMsg_CreateNaClChannel::ID);
+ false;
#endif
// We can't always tell from the message ID if rewriting is needed. Therefore,
@@ -319,7 +314,6 @@ bool NaClMessageScanner::ScanMessage(
base::Bind(&NaClMessageScanner::AuditNestedMessage,
base::Unretained(this));
switch (msg.type()) {
- CASE_FOR_MESSAGE(PpapiMsg_CreateNaClChannel)
CASE_FOR_MESSAGE(PpapiMsg_PPBAudio_NotifyAudioStreamCreated)
CASE_FOR_MESSAGE(PpapiMsg_PPPMessaging_HandleMessage)
CASE_FOR_MESSAGE(PpapiPluginMsg_ResourceReply)
« no previous file with comments | « ppapi/proxy/DEPS ('k') | ppapi/proxy/plugin_main_nacl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698