Issue 15070004: Fix LabelButton preferred size calculations.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15070004: Fix LabelButton preferred size calculations. (Closed)

Created:
7 years, 7 months ago by msw

Modified:
7 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, tfarina

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix LabelButton preferred size calculations. Label font/size changes in GetPreferredSize were causing infinite loops. ( the new-dialog-style edit bookmark dialog would crash on launch ) Rewrite the sizing code using a local Label object, fix for correctness too. Remove a redundant call to SetAccessibleName. BUG=155363 TEST=Button sizing is correct, no crashes on new-style edit bookmark dialog. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199921