nss/lib/certdb/alg1485.c - Issue 15067014: Fix the invalid read (heap-buffer-overflow) error in AppendAVA().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: nss/lib/certdb/alg1485.c

Issue 15067014: Fix the invalid read (heap-buffer-overflow) error in AppendAVA(). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/nss/

Patch Set: Sync Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: nss/lib/certdb/alg1485.c

===================================================================

--- nss/lib/certdb/alg1485.c (revision 200336)

+++ nss/lib/certdb/alg1485.c (working copy)

@@ -1036,8 +1036,10 @@

} else {

/* must truncate the escaped and quoted value */

char bigTmpBuf[TMPBUF_LEN * 3 + 3];

+ PORT_Assert(valueLen < sizeof tmpBuf);

rv = escapeAndQuote(bigTmpBuf, sizeof bigTmpBuf,

- (char *)avaValue->data, valueLen, &mode);

+ (char *)avaValue->data,

+ PR_MIN(avaValue->len, valueLen), &mode);

bigTmpBuf[valueLen--] = '\0'; /* hard stop here */

/* See if we're in the middle of a multi-byte UTF8 character */

« no previous file with comments | « README.chromium ('k') | patches/nss-appendava-invalid-read.patch » ('j') | no next file with comments »