Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issue 15061005: Fix CustomFrameViewAshTest.ResizeButtonToggleMaximize frame creation. (Closed)

Created:
7 years, 7 months ago by msw
Modified:
7 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, Daniel Erat
Visibility:
Public.

Description

Fix CustomFrameViewAshTest.ResizeButtonToggleMaximize frame creation. Always test CustomFrameViewAsh, which may not be the ash::Shell default. ( The new dialog style uses a BubbleFrameView for the default frame. ) ( We might backtrack on that, but this change seems good either way. ) BUG=166075 TEST=CustomFrameViewAshTest.ResizeButtonToggleMaximize passes with the new dialog style (--enable-new-dialog-style) R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199765

Patch Set 1 : Update CustomFrameViewAshTest.ResizeButtonToggleMaximize expectations. #

Patch Set 2 : Always use CustomFrameViewAsh in CustomFrameViewAshTest.*. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M ash/wm/custom_frame_view_ash_unittest.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
msw
Hey Dan, please take a look at your earliest opportunity; thanks! This CL (or similar, ...
7 years, 7 months ago (2013-05-12 23:05:56 UTC) #1
sky
LGTM
7 years, 7 months ago (2013-05-13 16:38:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15061005/4001
7 years, 7 months ago (2013-05-13 16:40:50 UTC) #3
commit-bot: I haz the power
7 years, 7 months ago (2013-05-13 17:55:34 UTC) #4
Message was sent while issue was closed.
Change committed as 199765

Powered by Google App Engine
This is Rietveld 408576698