Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8491)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java

Issue 1505913003: Add update menu item and app menu icon badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add code create 1dp transparent border in LocatoinBarPhone Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
index 295e06d5f2644e40e3d79e83bb7b1257fb728f34..7ffc05561b9e8161e3bca7ed64b96631082fcb9c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java
@@ -17,6 +17,7 @@ import android.view.MotionEvent;
import android.view.View;
import android.view.ViewGroup;
import android.widget.FrameLayout;
+import android.widget.ImageView;
import android.widget.ProgressBar;
import org.chromium.base.ApiCompatibilityUtils;
@@ -48,6 +49,8 @@ abstract class ToolbarLayout extends FrameLayout implements Toolbar {
* The ImageButton view that represents the menu button.
*/
protected TintedImageButton mMenuButton;
+ protected ImageView mMenuBadge;
+ protected View mMenuButtonWrapper;
private AppMenuButtonHelper mAppMenuButtonHelper;
protected final ColorStateList mDarkModeTint;
@@ -92,6 +95,9 @@ abstract class ToolbarLayout extends FrameLayout implements Toolbar {
}
mMenuButton = (TintedImageButton) findViewById(R.id.menu_button);
+ mMenuBadge = (ImageView) findViewById(R.id.menu_badge);
+ mMenuButtonWrapper = findViewById(R.id.menu_btn_wrapper);
gone 2015/12/08 22:24:24 nit: one space
Theresa 2015/12/10 03:53:18 Done.
+
// Initialize the provider to an empty version to avoid null checking everywhere.
mToolbarDataProvider = new ToolbarDataProvider() {
@Override

Powered by Google App Engine
This is Rietveld 408576698