chrome/android/java/res/layout-sw600dp/toolbar.xml - Issue 1505913003: Add update menu item and app menu icon badge

Side by Side Diff: chrome/android/java/res/layout-sw600dp/toolbar.xml

Issue 1505913003: Add update menu item and app menu icon badge (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add code create 1dp transparent border in LocatoinBarPhone Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/android/java/res/drawable-xxxhdpi/menu_update.png ('k') | chrome/android/java/res/layout/location_bar.xml » ('j') | chrome/android/java/res/layout/update_menu_item.xml » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <?xml version="1.0" encoding="utf-8"?>	1 <?xml version="1.0" encoding="utf-8"?>

2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.	2 <!-- Copyright 2015 The Chromium Authors. All rights reserved.

3 Use of this source code is governed by a BSD-style license that can be	3 Use of this source code is governed by a BSD-style license that can be

4 found in the LICENSE file. -->	4 found in the LICENSE file. -->

5	5

6 <!-- The toolbar containing the URL bar, back button, and NTP button.	6 <!-- The toolbar containing the URL bar, back button, and NTP button.

7 -->	7 -->

8	8

9 <org.chromium.chrome.browser.toolbar.ToolbarTablet	9 <org.chromium.chrome.browser.toolbar.ToolbarTablet

10 xmlns:android="http://schemas.android.com/apk/res/android"	10 xmlns:android="http://schemas.android.com/apk/res/android"

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42 android:id="@+id/location_bar"	42 android:id="@+id/location_bar"

43 android:layout_width="0dp"	43 android:layout_width="0dp"

44 android:layout_height="match_parent"	44 android:layout_height="match_parent"

45 android:layout_marginBottom="5dp"	45 android:layout_marginBottom="5dp"

46 android:layout_marginTop="5dp"	46 android:layout_marginTop="5dp"

47 android:layout_weight="1"	47 android:layout_weight="1"

48 android:layout_gravity="top\|center"	48 android:layout_gravity="top\|center"

49 android:background="@drawable/textbox"	49 android:background="@drawable/textbox"

50 android:paddingEnd="1dp"	50 android:paddingEnd="1dp"

51 android:paddingStart="2dp"	51 android:paddingStart="2dp"

52 />	52 />
	gone 2015/12/08 22:24:23 nit: should go on the same line as the last attrib nit: should go on the same line as the last attribute Theresa 2015/12/10 03:53:17 Done. Show quoted text On 2015/12/08 22:24:23, dfalcantara wrote: > nit: should go on the same line as the last attribute Done.
53 <ImageButton	53 <ImageButton

54 android:id="@+id/tab_switcher_button"	54 android:id="@+id/tab_switcher_button"

55 style="@style/ToolbarButton"	55 style="@style/ToolbarButton"

56 android:contentDescription="@string/accessibility_toolbar_btn_tabswi tcher_toggle"	56 android:contentDescription="@string/accessibility_toolbar_btn_tabswi tcher_toggle"

57 android:visibility="gone" />	57 android:visibility="gone" />

58 <org.chromium.chrome.browser.widget.TintedImageButton	58 <FrameLayout
	gone 2015/12/08 22:24:23 1) Does it make sense to pull this FrameLayout + c 1) Does it make sense to pull this FrameLayout + children thing out into its own Layout file, then include it from the three locations I see so far? 2) nit: could you add some newlines to break up this monolithic block of stuff? The attributes are indented at the same level as the children and makes it hard to parse. Theresa 2015/12/10 03:53:17 1. All of the menu_buttons have different layout_w Show quoted text On 2015/12/08 22:24:23, dfalcantara wrote: > 1) Does it make sense to pull this FrameLayout + children thing out into its own > Layout file, then include it from the three locations I see so far? > > 2) nit: could you add some newlines to break up this monolithic block of stuff? > The attributes are indented at the same level as the children and makes it hard > to parse. 1. All of the menu_buttons have different layout_width and padding so extracting and the FrameLayout for reuse between both toolbar.xml files and location_bar.xml will be difficult, but I'm not totally opposed to doing that. I did extract some of the menu_badge style into a styles.xml. Another idea, suggested by newt@, is to make a new class that extends TintedImageButton, override the onDraw method and draw the badge in the correct spot (if it should be shown). I'm most inclined to leave the code how it is since the badge is experimental (and less work is better), but can easily be talked into changing it. 2. done (are there too many now?) gone 2015/12/10 21:45:07 Looks good. If this becomes a permanent thing I g Show quoted text On 2015/12/10 03:53:17, Theresa Wellington wrote: > On 2015/12/08 22:24:23, dfalcantara wrote: > > 1) Does it make sense to pull this FrameLayout + children thing out into its > own > > Layout file, then include it from the three locations I see so far? > > > > 2) nit: could you add some newlines to break up this monolithic block of > stuff? > > The attributes are indented at the same level as the children and makes it > hard > > to parse. > > 1. All of the menu_buttons have different layout_width and padding so extracting > and the FrameLayout for reuse between both toolbar.xml files and > location_bar.xml will be difficult, but I'm not totally opposed to doing that. I > did extract some of the menu_badge style into a styles.xml. > > Another idea, suggested by newt@, is to make a new class that extends > TintedImageButton, override the onDraw method and draw the badge in the correct > spot (if it should be shown). > > I'm most inclined to leave the code how it is since the badge is experimental > (and less work is better), but can easily be talked into changing it. > > 2. done (are there too many now?) Looks good. If this becomes a permanent thing I guess we could revisit. Theresa 2015/12/11 19:44:46 Acknowledged. Show quoted text On 2015/12/10 21:45:07, dfalcantara wrote: > On 2015/12/10 03:53:17, Theresa Wellington wrote: > > On 2015/12/08 22:24:23, dfalcantara wrote: > > > 1) Does it make sense to pull this FrameLayout + children thing out into its > > own > > > Layout file, then include it from the three locations I see so far? > > > > > > 2) nit: could you add some newlines to break up this monolithic block of > > stuff? > > > The attributes are indented at the same level as the children and makes it > > hard > > > to parse. > > > > 1. All of the menu_buttons have different layout_width and padding so > extracting > > and the FrameLayout for reuse between both toolbar.xml files and > > location_bar.xml will be difficult, but I'm not totally opposed to doing that. > I > > did extract some of the menu_badge style into a styles.xml. > > > > Another idea, suggested by newt@, is to make a new class that extends > > TintedImageButton, override the onDraw method and draw the badge in the > correct > > spot (if it should be shown). > > > > I'm most inclined to leave the code how it is since the badge is experimental > > (and less work is better), but can easily be talked into changing it. > > > > 2. done (are there too many now?) > > Looks good. If this becomes a permanent thing I guess we could revisit. Acknowledged.
59 android:id="@+id/menu_button"	59 android:layout_width="wrap_content"

60 style="@style/ToolbarButton"	60 android:layout_height="wrap_content"

61 android:src="@drawable/btn_menu"	61 android:id="@+id/menu_btn_wrapper" >
	gone 2015/12/08 22:24:23 nit: menu_button_wrapper? I think the btn_ design nit: menu_button_wrapper? I think the btn_ designation is just for filenames, and the IDs above use forward_button / btn_forward as well. Theresa 2015/12/10 03:53:17 Done. Show quoted text On 2015/12/08 22:24:23, dfalcantara wrote: > nit: menu_button_wrapper? I think the btn_ designation is just for filenames, > and the IDs above use forward_button / btn_forward as well. Done.
62 android:contentDescription="@string/accessibility_toolbar_btn_menu"	62 <org.chromium.chrome.browser.widget.TintedImageButton

63 android:layout_width="43dp"	63 android:id="@+id/menu_button"

64 android:paddingEnd="3.5dp" />	64 style="@style/ToolbarButton"

	65 android:src="@drawable/btn_menu"

	66 android:contentDescription="@string/accessibility_toolbar_btn_me nu"

	67 android:layout_width="43dp"

	68 android:paddingEnd="3.5dp" />

	69 <ImageView

	70 android:id="@+id/menu_badge"

	71 android:src="@drawable/badge_update"

	72 android:layout_height="@dimen/menu_badge_size"

	73 android:layout_width="@dimen/menu_badge_size"

	74 android:layout_marginBottom="14dp"

	75 android:layout_marginEnd="9.5dp"

	76 android:layout_gravity="end\|bottom"

	77 android:contentDescription="@string/accessibility_toolbar_update _badge"
	gone 2015/12/08 22:24:23 I don't know if it makes sense to apply the access I don't know if it makes sense to apply the accessibility description to the tiny badge; does it make sense to apply a common accessibility string to the FrameLayout instead? One that changes depending on whether an update is available? Theresa 2015/12/10 03:53:17 I don't think views inherit contentDescriptions fr Show quoted text On 2015/12/08 22:24:23, dfalcantara wrote: > I don't know if it makes sense to apply the accessibility description to the > tiny badge; does it make sense to apply a common accessibility string to the > FrameLayout instead? One that changes depending on whether an update is > available? I don't think views inherit contentDescriptions from their parent (if I move the contentDescription from the TintedImageButton to the FrameLayout I get "Button 28, unlabeled"). I could add code to set it on the menu_button, but I don't think that's necessary. I mostly added a content description to the badge because lint complained that I didn't have one. I don't think the accessibility string needs to change when the menu is badged, so I made the badge non-focusable, labeled it as not important for accessibility and set the contentDescription to null. A tap on the menu button reads "More options button", which is accurate (and concise) whether a badge is present or not. gone 2015/12/10 21:45:07 You might be able to apply a @null contentDescript Show quoted text On 2015/12/10 03:53:17, Theresa Wellington wrote: > On 2015/12/08 22:24:23, dfalcantara wrote: > > I don't know if it makes sense to apply the accessibility description to the > > tiny badge; does it make sense to apply a common accessibility string to the > > FrameLayout instead? One that changes depending on whether an update is > > available? > > I don't think views inherit contentDescriptions from their parent (if I move the > contentDescription from the TintedImageButton to the FrameLayout I get "Button > 28, unlabeled"). I could add code to set it on the menu_button, but I don't > think that's necessary. > > I mostly added a content description to the badge because lint complained that I > didn't have one. I don't think the accessibility string needs to change when the > menu is badged, so I made the badge non-focusable, labeled it as not important > for accessibility and set the contentDescription to null. A tap on the menu > button reads "More options button", which is accurate (and concise) whether a > badge is present or not. You might be able to apply a @null contentDescription, or define the ImageView as being unimportant for accessibility: http://developer.android.com/reference/android/view/View.html#attr_android:im... Theresa 2015/12/11 19:44:46 I set the contentDescription to null and defined i Show quoted text On 2015/12/10 21:45:07, dfalcantara wrote: > On 2015/12/10 03:53:17, Theresa Wellington wrote: > > On 2015/12/08 22:24:23, dfalcantara wrote: > > > I don't know if it makes sense to apply the accessibility description to the > > > tiny badge; does it make sense to apply a common accessibility string to the > > > FrameLayout instead? One that changes depending on whether an update is > > > available? > > > > I don't think views inherit contentDescriptions from their parent (if I move > the > > contentDescription from the TintedImageButton to the FrameLayout I get "Button > > 28, unlabeled"). I could add code to set it on the menu_button, but I don't > > think that's necessary. > > > > I mostly added a content description to the badge because lint complained that > I > > didn't have one. I don't think the accessibility string needs to change when > the > > menu is badged, so I made the badge non-focusable, labeled it as not important > > for accessibility and set the contentDescription to null. A tap on the menu > > button reads "More options button", which is accurate (and concise) whether a > > badge is present or not. > > You might be able to apply a @null contentDescription, or define the ImageView > as being unimportant for accessibility: > http://developer.android.com/reference/android/view/View.html#attr_android:im... I set the contentDescription to null and defined it as being unimportant for accessibility (in styles.xml).
	78 android:visibility="gone" />

	79 </FrameLayout>

65 </LinearLayout>	80 </LinearLayout>

66 </org.chromium.chrome.browser.toolbar.ToolbarTablet>	81 </org.chromium.chrome.browser.toolbar.ToolbarTablet>

OLD	NEW