content/common/view_messages.h - Issue 15057004: Week picker for android

Side by Side Diff: content/common/view_messages.h

Issue 15057004: Week picker for android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « content/browser/web_contents/web_contents_impl.cc ('k') | content/public/android/java/res/layout/week_picker.xml » ('j') | content/public/android/java/src/org/chromium/content/browser/input/WeekPicker.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // IPC messages for page rendering.	5 // IPC messages for page rendering.

6 // Multiply-included message file, hence no include guard.	6 // Multiply-included message file, hence no include guard.

7	7

8 #include "base/process.h"	8 #include "base/process.h"

9 #include "base/shared_memory.h"	9 #include "base/shared_memory.h"

10 #include "base/string16.h"	10 #include "base/string16.h"

(...skipping 342 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
353 IPC_STRUCT_END()	353 IPC_STRUCT_END()

354	354

355 IPC_STRUCT_BEGIN(ViewHostMsg_DateTimeDialogValue_Params)	355 IPC_STRUCT_BEGIN(ViewHostMsg_DateTimeDialogValue_Params)

356 IPC_STRUCT_MEMBER(int, dialog_type)	356 IPC_STRUCT_MEMBER(int, dialog_type)

357 IPC_STRUCT_MEMBER(int, year)	357 IPC_STRUCT_MEMBER(int, year)

358 IPC_STRUCT_MEMBER(int, month)	358 IPC_STRUCT_MEMBER(int, month)

359 IPC_STRUCT_MEMBER(int, day)	359 IPC_STRUCT_MEMBER(int, day)

360 IPC_STRUCT_MEMBER(int, hour)	360 IPC_STRUCT_MEMBER(int, hour)

361 IPC_STRUCT_MEMBER(int, minute)	361 IPC_STRUCT_MEMBER(int, minute)

362 IPC_STRUCT_MEMBER(int, second)	362 IPC_STRUCT_MEMBER(int, second)

	363 IPC_STRUCT_MEMBER(int, week_year)
	Miguel Garcia 2013/05/10 15:17:59 if we really need these two ints let's call them i if we really need these two ints let's call them iso_week_year and let's rename year to something more concrete (like iso_year?) otherwise it's really hard to understand what's the difference (in fact I don't really know what the difference is yet :) ) keishi 2013/05/14 13:47:47 In this patch I removed week_year and reused the y Show quoted text On 2013/05/10 15:17:59, Miguel Garcia wrote: > if we really need these two ints let's call them iso_week_year and let's rename > year to something more concrete (like iso_year?) otherwise it's really hard to > understand what's the difference (in fact I don't really know what the > difference is yet :) ) In this patch I removed week_year and reused the year field. Miguel Garcia 2013/05/17 11:23:38 Great, I think this makes more sense On 2013/05/1 Great, I think this makes more sense On 2013/05/14 13:47:47, keishi1 wrote: Show quoted text > On 2013/05/10 15:17:59, Miguel Garcia wrote: > > if we really need these two ints let's call them iso_week_year and let's > rename > > year to something more concrete (like iso_year?) otherwise it's really hard to > > understand what's the difference (in fact I don't really know what the > > difference is yet :) ) > In this patch I removed week_year and reused the year field.
	364 IPC_STRUCT_MEMBER(int, week)

363 IPC_STRUCT_END()	365 IPC_STRUCT_END()

364	366

365 IPC_STRUCT_BEGIN(ViewHostMsg_DidFailProvisionalLoadWithError_Params)	367 IPC_STRUCT_BEGIN(ViewHostMsg_DidFailProvisionalLoadWithError_Params)

366 // The frame ID for the failure report.	368 // The frame ID for the failure report.

367 IPC_STRUCT_MEMBER(int64, frame_id)	369 IPC_STRUCT_MEMBER(int64, frame_id)

368 // True if this is the top-most frame.	370 // True if this is the top-most frame.

369 IPC_STRUCT_MEMBER(bool, is_main_frame)	371 IPC_STRUCT_MEMBER(bool, is_main_frame)

370 // Error code as reported in the DidFailProvisionalLoad callback.	372 // Error code as reported in the DidFailProvisionalLoad callback.

371 IPC_STRUCT_MEMBER(int, error_code)	373 IPC_STRUCT_MEMBER(int, error_code)

372 // An error message generated from the error_code. This can be an empty	374 // An error message generated from the error_code. This can be an empty

(...skipping 1904 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
2277 // cached by the OS. Please see RenderMessageFilter::OnPreCacheFontCharacters	2279 // cached by the OS. Please see RenderMessageFilter::OnPreCacheFontCharacters

2278 // for details.	2280 // for details.

2279 IPC_SYNC_MESSAGE_CONTROL2_0(ViewHostMsg_PreCacheFontCharacters,	2281 IPC_SYNC_MESSAGE_CONTROL2_0(ViewHostMsg_PreCacheFontCharacters,

2280 LOGFONT /* font_data */,	2282 LOGFONT /* font_data */,

2281 string16 /* characters */)	2283 string16 /* characters */)

2282 #endif	2284 #endif

2283	2285

2284 // Adding a new message? Stick to the sort order above: first platform	2286 // Adding a new message? Stick to the sort order above: first platform

2285 // independent ViewMsg, then ifdefs for platform specific ViewMsg, then platform	2287 // independent ViewMsg, then ifdefs for platform specific ViewMsg, then platform

2286 // independent ViewHostMsg, then ifdefs for platform specific ViewHostMsg.	2288 // independent ViewHostMsg, then ifdefs for platform specific ViewHostMsg.

OLD	NEW