Open Source AsyncDNS.*, DNS.* and DnsProbe.* histograms.

Open Source AsyncDNS.*, DNS.* and DnsProbe.* histograms.

Added DNS.EmptyAddressListAndNoError histogram, removed unused DnsImpact2 and DnsImpact3 field trials.

Corresponding internal CL is here: https://chromereviews.googleplex.com/8120013/

BUG=223859
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200539

[szym, 2013-05-13 19:19:26]

https://chromiumcodereview.appspot.com/15053003/diff/1/tools/metrics/histogra...
File tools/metrics/histograms/histograms.xml (right):

https://chromiumcodereview.appspot.com/15053003/diff/1/tools/metrics/histogra...
tools/metrics/histograms/histograms.xml:1258: <histogram
name="DNS.ResolveUnspecWaste" enum="ResolutionUnspecWasteCategory">
This histogram is gone. The enum is no longer needed.

[mef, 2013-05-13 21:20:11]

https://codereview.chromium.org/15053003/diff/1/tools/metrics/histograms/hist...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/15053003/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:931: <summary>
Jim, 

thank you for your suggestion on another CL. In retrospect, we could've added
this count as a bucket to another histogram, probably ResolutionCategory enum.
The idea here is to try to explicitly record scenarios where AsyncDNS reports
failure, but ProcDNS succeeds, and this appears to be one of the plausible
explanations.

https://codereview.chromium.org/15053003/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:1258: <histogram
name="DNS.ResolveUnspecWaste" enum="ResolutionUnspecWasteCategory">
On 2013/05/13 19:19:26, szym wrote:
> This histogram is gone. The enum is no longer needed.

Done.

[Ilya Sherman, 2013-05-13 22:59:50]

Could you please link me to the internal CL that's the inverse of this one?

https://codereview.chromium.org/15053003/diff/1/tools/metrics/histograms/hist...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/15053003/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:11277: </fieldtrial>
Please make this CL purely a copy/paste out of the internal file, and split off
the change to remove these field trials to a separate, follow-up CL.

[mef, 2013-05-14 15:55:03]

Hi Ilya,

PTAL. Corresponding internal CL is here:
https://chromereviews.googleplex.com/8120013/

I've split removal of DnsImpact2/3 field trials into separate CL. I was not able
to put unused DnsImpact field trial from internal histograms.xml into open
source as it references some internal histograms.

thanks,
-m

https://codereview.chromium.org/15053003/diff/1/tools/metrics/histograms/hist...
File tools/metrics/histograms/histograms.xml (left):

https://codereview.chromium.org/15053003/diff/1/tools/metrics/histograms/hist...
tools/metrics/histograms/histograms.xml:11277: </fieldtrial>
On 2013/05/13 22:59:50, Ilya Sherman wrote:
> Please make this CL purely a copy/paste out of the internal file, and split
off
> the change to remove these field trials to a separate, follow-up CL.

Done.

[Ilya Sherman, 2013-05-14 22:01:50]

https://codereview.chromium.org/15053003/diff/10001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/15053003/diff/10001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:934: </histogram>
Please move this into a separate CL.

[mef, 2013-05-15 15:59:00]

Ilya,

PTAL. I've Copied DNS.ResolveUnspecWaste from internal histograms, and moved
DNS.EmptyAddressListAndNoError into separate CL.

https://codereview.chromium.org/15053003/diff/10001/tools/metrics/histograms/...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/15053003/diff/10001/tools/metrics/histograms/...
tools/metrics/histograms/histograms.xml:934: </histogram>
On 2013/05/14 22:01:50, Ilya Sherman wrote:
> Please move this into a separate CL.

Done.

[Ilya Sherman, 2013-05-15 21:12:41]

LGTM, thanks.

[commit-bot: I haz the power, 2013-05-15 21:52:29]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mef@chromium.org/15053003/18001

[commit-bot: I haz the power, 2013-05-16 06:44:26]

Retried try job too often on win7_aura for step(s) content_browsertests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&...

[commit-bot: I haz the power, 2013-05-16 14:10:48]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mef@chromium.org/15053003/18001

[commit-bot: I haz the power, 2013-05-16 15:25:28]

Change committed as 200539