Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3372)

Unified Diff: chrome/browser/extensions/updater/extension_updater.cc

Issue 15051010: Move [Get|Set]UpdateURLData from ExtensionPrefs to ExtensionAPI (aka Module) (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_prefs.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/updater/extension_updater.cc
diff --git a/chrome/browser/extensions/updater/extension_updater.cc b/chrome/browser/extensions/updater/extension_updater.cc
index 4db6feb3be44a05167e4d325ed415e02fa310166..7ca8f13220080388ccee7d423ed6309f69336a7b 100644
--- a/chrome/browser/extensions/updater/extension_updater.cc
+++ b/chrome/browser/extensions/updater/extension_updater.cc
@@ -16,6 +16,7 @@
#include "base/stl_util.h"
#include "base/strings/string_number_conversions.h"
#include "base/strings/string_split.h"
+#include "chrome/browser/extensions/api/module/module.h"
#include "chrome/browser/extensions/blacklist.h"
#include "chrome/browser/extensions/crx_installer.h"
#include "chrome/browser/extensions/extension_service.h"
@@ -544,7 +545,9 @@ bool ExtensionUpdater::GetPingDataForExtension(
std::string ExtensionUpdater::GetUpdateUrlData(const std::string& id) {
DCHECK(alive_);
- return extension_prefs_->GetUpdateUrlData(id);
+ std::string data;
+ extension_prefs_->ReadPrefAsString(id, extension::kUpdateURLData, &data);
Yoyo Zhou 2013/05/15 18:49:49 I think it'd be better to have an accessor in modu
Devlin 2013/05/15 23:12:29 Agreed, and done.
+ return data;
}
bool ExtensionUpdater::IsExtensionPending(const std::string& id) {
« no previous file with comments | « chrome/browser/extensions/extension_prefs.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698