Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 15042008: Remove the idle logout dialog extra border. (Closed)

Created:
7 years, 7 months ago by msw
Modified:
7 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove the idle logout dialog extra border. IdleLogoutDialogView uses Widget::CreateWindowWithParent. Use DialogDelegate::CreateDialogWidget instead. Does not change the old-style appearance or behavior. See before/after pics at http://crbug.com/166075#c77 I triggered the dialog with debug code in Patch Set 1. BUG=166075 TEST=new-style idle logout dialog does not have an extra border. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200666

Patch Set 1 #

Patch Set 2 : Remove debugging code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chrome/browser/chromeos/ui/idle_logout_dialog_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
msw
Hey Scott, please take a look; thanks!
7 years, 7 months ago (2013-05-15 23:02:26 UTC) #1
sky
LGTM
7 years, 7 months ago (2013-05-16 14:44:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15042008/2001
7 years, 7 months ago (2013-05-16 16:14:08 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=115078
7 years, 7 months ago (2013-05-16 16:44:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15042008/2001
7 years, 7 months ago (2013-05-16 16:56:47 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_chromeos for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chromeos&number=115126
7 years, 7 months ago (2013-05-16 17:38:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/15042008/2001
7 years, 7 months ago (2013-05-16 19:43:51 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-17 00:20:45 UTC) #8
Message was sent while issue was closed.
Change committed as 200666

Powered by Google App Engine
This is Rietveld 408576698