Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Unified Diff: chrome/browser/ui/search/instant_extended_interactive_uitest.cc

Issue 15041004: Replace PruneAllButActive with PruneAllButVisible. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_extended_interactive_uitest.cc
diff --git a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
index 1f806bdf2f0a529d7974a02e2df2310bcb1c51bf..44c9229535cc035b7489d2e95c751f2a81d5617d 100644
--- a/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
+++ b/chrome/browser/ui/search/instant_extended_interactive_uitest.cc
@@ -882,6 +882,7 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest, PreloadedNTPRenderViewGone) {
EXPECT_EQ(NULL, instant()->ntp());
// Open new tab. Should use local NTP.
+ // TODO(creis): Same problem.
ui_test_utils::NavigateToURLWithDisposition(
browser(),
GURL(chrome::kChromeUINewTabURL),
@@ -904,6 +905,7 @@ IN_PROC_BROWSER_TEST_F(InstantExtendedTest, PreloadedNTPDoesntSupportInstant) {
EXPECT_TRUE(instant()->ntp()->IsLocal());
// Open new tab. Should use local NTP.
+ // TODO(creis): Same problem.
ui_test_utils::NavigateToURLWithDisposition(
browser(),
GURL(chrome::kChromeUINewTabURL),
@@ -2454,6 +2456,10 @@ class InstantExtendedFirstTabTest : public InProcessBrowserTest,
IN_PROC_BROWSER_TEST_F(
InstantExtendedFirstTabTest, DISABLED_RedirectToLocalOnLoadFailure) {
// Create a new window to test the first NTP load.
+ // TODO(creis): This fails in BrowserInstantController's
+ // MaybeSwapInInstantNTPContents because the pending entry hasn't
+ // committed yet. It's trying to SwapInInstantNTP as part of the OpenURL
+ // call, which can't work. (What if the navigation were to fail?)
ui_test_utils::NavigateToURLWithDisposition(
browser(),
GURL(chrome::kChromeUINewTabURL),
@@ -2485,6 +2491,7 @@ IN_PROC_BROWSER_TEST_F(
// Instant tab contents should be preloaded.
ASSERT_NE(static_cast<InstantTab*>(NULL), instant()->instant_tab());
+ // TODO(creis): This is where the test fails.
EXPECT_TRUE(instant()->instant_tab()->IsLocal());
}

Powered by Google App Engine
This is Rietveld 408576698