chrome/browser/ui/browser_commands.cc - Issue 15041004: Replace PruneAllButActive with PruneAllButVisible.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser_commands.cc

Issue 15041004: Replace PruneAllButActive with PruneAllButVisible. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Change to CHECK. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/browser_commands.cc

diff --git a/chrome/browser/ui/browser_commands.cc b/chrome/browser/ui/browser_commands.cc

index fd1c0adf77e95dedc17aede0ec10c19c3cf927e7..c1d4bba4c7700dc061aabf0744ce9720097ab936 100644

--- a/chrome/browser/ui/browser_commands.cc

+++ b/chrome/browser/ui/browser_commands.cc

@@ -1008,7 +1008,8 @@ void ViewSource(Browser* browser,

// Note that Clone does not copy the pending or transient entries, so the

// active entry in view_source_contents will be the last committed entry.

WebContents* view_source_contents = contents->Clone();

- view_source_contents->GetController().PruneAllButActive();

+ DCHECK(view_source_contents->GetController().CanPruneAllButVisible());

+ view_source_contents->GetController().PruneAllButVisible();

NavigationEntry* active_entry =

view_source_contents->GetController().GetActiveEntry();

if (!active_entry)