Issue 15039018: Gamepad: Don't emit BOM in Gamepad ID.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15039018: Gamepad: Don't emit BOM in Gamepad ID. (Closed)

Created:
7 years, 7 months ago by teravest

Modified:
7 years, 7 months ago

Reviewers:
scottmg

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, sail+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Gamepad: Don't emit BOM in Gamepad ID. This change makes the gamepad ID little-endian and not include a byte-order mark, making it consistent with other platforms. I tested that the html5rocks.com gamepad tester still emits this correct ID for the gamepad after this change. BUG=229580 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199743

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/browser/gamepad/gamepad_platform_data_fetcher_mac.mm	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/15039018/1

7 years, 7 months ago (2013-05-10 21:29:03 UTC) #3

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=126572

7 years, 7 months ago (2013-05-10 22:32:25 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/teravest@chromium.org/15039018/1

7 years, 7 months ago (2013-05-13 14:03:46 UTC) #5

Message was sent while issue was closed.

Change committed as 199743

Expand Messages | Collapse Messages