Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Issue 15039008: Add browser resource host for Apps v2 APIs in Pepper. (Closed)

Created:
7 years, 7 months ago by yzshen1
Modified:
7 years, 7 months ago
Reviewers:
raymes
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Add browser resource host for Apps v2 APIs in Pepper. This CL doesn't include the logic of interacting with extension function dispatcher. BUG=226303 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199143

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -37 lines) Patch
M chrome/browser/renderer_host/pepper/chrome_browser_pepper_host_factory.cc View 1 2 2 chunks +17 lines, -0 lines 0 comments Download
A chrome/browser/renderer_host/pepper/pepper_extensions_common_message_filter.h View 1 chunk +75 lines, -0 lines 0 comments Download
A chrome/browser/renderer_host/pepper/pepper_extensions_common_message_filter.cc View 1 1 chunk +90 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M ppapi/proxy/extensions_common_resource.h View 1 chunk +22 lines, -6 lines 0 comments Download
M ppapi/proxy/extensions_common_resource.cc View 4 chunks +34 lines, -5 lines 0 comments Download
M ppapi/thunk/extensions_common_api.h View 1 chunk +12 lines, -6 lines 0 comments Download
M ppapi/thunk/ppb_ext_alarms_thunk.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M ppapi/thunk/ppb_ext_socket_thunk.cc View 15 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
yzshen1
Hi, Raymes. Would you please take a look? This is just the skeleton. Thanks!
7 years, 7 months ago (2013-05-07 19:44:01 UTC) #1
raymes
lgtm https://codereview.chromium.org/15039008/diff/1/chrome/browser/renderer_host/pepper/pepper_extensions_common_message_filter.cc File chrome/browser/renderer_host/pepper/pepper_extensions_common_message_filter.cc (right): https://codereview.chromium.org/15039008/diff/1/chrome/browser/renderer_host/pepper/pepper_extensions_common_message_filter.cc#newcode19 chrome/browser/renderer_host/pepper/pepper_extensions_common_message_filter.cc:19: PepperExtensionsCommonMessageFilter* please add a // static comment
7 years, 7 months ago (2013-05-08 18:28:56 UTC) #2
yzshen1
Thanks, Raymes! https://codereview.chromium.org/15039008/diff/1/chrome/browser/renderer_host/pepper/pepper_extensions_common_message_filter.cc File chrome/browser/renderer_host/pepper/pepper_extensions_common_message_filter.cc (right): https://codereview.chromium.org/15039008/diff/1/chrome/browser/renderer_host/pepper/pepper_extensions_common_message_filter.cc#newcode19 chrome/browser/renderer_host/pepper/pepper_extensions_common_message_filter.cc:19: PepperExtensionsCommonMessageFilter* On 2013/05/08 18:28:56, raymes wrote: > ...
7 years, 7 months ago (2013-05-08 19:38:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/15039008/5001
7 years, 7 months ago (2013-05-08 19:38:30 UTC) #4
commit-bot: I haz the power
Failed to apply patch for chrome/browser/renderer_host/pepper/chrome_browser_pepper_host_factory.cc: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-08 19:38:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/15039008/13001
7 years, 7 months ago (2013-05-08 19:47:55 UTC) #6
commit-bot: I haz the power
7 years, 7 months ago (2013-05-09 06:01:36 UTC) #7
Message was sent while issue was closed.
Change committed as 199143

Powered by Google App Engine
This is Rietveld 408576698