Load policy for extensions at the Mac policy provider.

Load policy for extensions at the Mac policy provider.

The Mac policy provider loads policies for the browser. This change makes it
additionally load policies for the extensions described in the PolicyDomainDescriptor
for extensions.

BUG=108992
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=202597

[Joao da Silva, 2013-05-14 16:48:11]

This depends on https://codereview.chromium.org/14587009.

@mnissler: please review. The windows provider will be modified to use the
schemas too, and eventually the Chrome policies can also come from a schema
descriptor, which solves the structured policy problem (but we need to compile
the Chrome schema in, somehow).

@kalman: FYI

[Mattias Nissler (ping if slow), 2013-05-15 10:42:14]

https://codereview.chromium.org/15038007/diff/1/chrome/browser/policy/policy_...
File chrome/browser/policy/policy_loader_mac.cc (right):

https://codereview.chromium.org/15038007/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_mac.cc:101: // Load chrome policy.
I guess that this could use a TODO explaining that we want to use a schema
instead?

https://codereview.chromium.org/15038007/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_mac.cc:133:
supported_domains[POLICY_DOMAIN_EXTENSIONS] = "extensions";
I guess this could be factored into a helper function that does a switch over
PolicyDomain? That would be preferable so you see this dependency on adding
domains.

https://codereview.chromium.org/15038007/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_mac.cc:236: policy->Set(it_type->first,
POLICY_LEVEL_MANDATORY,
mandatory vs. recommended policy level?

[Joao da Silva, 2013-05-19 13:22:01]

@pastarmovj: please review this, thanks!

https://codereview.chromium.org/15038007/diff/1/chrome/browser/policy/policy_...
File chrome/browser/policy/policy_loader_mac.cc (right):

https://codereview.chromium.org/15038007/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_mac.cc:101: // Load chrome policy.
On 2013/05/15 10:42:14, Mattias Nissler wrote:
> I guess that this could use a TODO explaining that we want to use a schema
> instead?

Done.

https://codereview.chromium.org/15038007/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_mac.cc:133:
supported_domains[POLICY_DOMAIN_EXTENSIONS] = "extensions";
On 2013/05/15 10:42:14, Mattias Nissler wrote:
> I guess this could be factored into a helper function that does a switch over
> PolicyDomain? That would be preferable so you see this dependency on adding
> domains.

Done.

https://codereview.chromium.org/15038007/diff/1/chrome/browser/policy/policy_...
chrome/browser/policy/policy_loader_mac.cc:236: policy->Set(it_type->first,
POLICY_LEVEL_MANDATORY,
On 2013/05/15 10:42:14, Mattias Nissler wrote:
> mandatory vs. recommended policy level?

Done.

[pastarmovj, 2013-05-21 08:37:56]

lgtm with a nitty nit.

https://codereview.chromium.org/15038007/diff/11001/chrome/browser/policy/pol...
File chrome/browser/policy/policy_loader_mac.cc (right):

https://codereview.chromium.org/15038007/diff/11001/chrome/browser/policy/pol...
chrome/browser/policy/policy_loader_mac.cc:101: // Load chrome policy.
nitty nit: s/chrome/Chrome's/

[Joao da Silva, 2013-05-27 12:14:59]

Thanks for the review.

https://codereview.chromium.org/15038007/diff/11001/chrome/browser/policy/pol...
File chrome/browser/policy/policy_loader_mac.cc (right):

https://codereview.chromium.org/15038007/diff/11001/chrome/browser/policy/pol...
chrome/browser/policy/policy_loader_mac.cc:101: // Load chrome policy.
On 2013/05/21 08:37:56, pastarmovj wrote:
> nitty nit: s/chrome/Chrome's/

Done.

[commit-bot: I haz the power, 2013-05-27 16:42:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/15038007/21001

[commit-bot: I haz the power, 2013-05-27 19:18:17]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-05-27 21:57:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/15038007/21001

[commit-bot: I haz the power, 2013-05-28 00:14:55]

Retried try job too often on mac_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-05-28 11:36:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/15038007/45001

[commit-bot: I haz the power, 2013-05-28 13:29:41]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-28 13:54:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/15038007/45001

[commit-bot: I haz the power, 2013-05-28 15:48:44]

Retried try job too often on linux_chromeos for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-05-28 16:27:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/15038007/45001

[commit-bot: I haz the power, 2013-05-28 17:44:19]

Change committed as 202597