Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 15031002: Implement TTS dispatcher using RenderProcessObserver instead of MessageFilter. (Closed)

Created:
7 years, 7 months ago by dmazzoni
Modified:
7 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Implement TTS dispatcher using RenderProcessObserver instead of MessageFilter. That guarantees the logic happens on the right thread. BUG=171887 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198786

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M chrome/renderer/tts_dispatcher.h View 3 chunks +9 lines, -11 lines 0 comments Download
M chrome/renderer/tts_dispatcher.cc View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dmazzoni
7 years, 7 months ago (2013-05-07 08:06:56 UTC) #1
tommi (sloooow) - chröme
lgtm
7 years, 7 months ago (2013-05-07 09:46:29 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/15031002/1
7 years, 7 months ago (2013-05-07 09:46:40 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=1765
7 years, 7 months ago (2013-05-07 09:51:50 UTC) #4
dmazzoni
+thestig for OWNERS review
7 years, 7 months ago (2013-05-07 13:56:51 UTC) #5
Lei Zhang
lgtm
7 years, 7 months ago (2013-05-07 18:23:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/15031002/1
7 years, 7 months ago (2013-05-07 18:24:07 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_rel for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=125113
7 years, 7 months ago (2013-05-07 18:57:04 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/15031002/1
7 years, 7 months ago (2013-05-07 20:13:42 UTC) #9
commit-bot: I haz the power
7 years, 7 months ago (2013-05-07 20:13:57 UTC) #10
Message was sent while issue was closed.
Change committed as 198786

Powered by Google App Engine
This is Rietveld 408576698