Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 15030007: Enable the (color-index) media query feature for non-indexed screens (Closed)

Created:
7 years, 7 months ago by kenneth.r.christiansen
Modified:
7 years, 7 months ago
CC:
blink-reviews, apavlov+blink_chromium.org, eae+blinkwatch, kenneth.christiansen, darktears
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Enable the (color-index) media query feature for non-indexed screens According to online documentation Opera, Internet Explorer and Firefox all supports the media query feature which is part of the W3C Recommendation http://www.w3.org/TR/css3-mediaqueries/ Original patch by Rune Lillesveen <rune@opera.com>;, but with minor changes and updated tests. WKBUG=114468 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150156

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -3 lines) Patch
A LayoutTests/fast/media/mq-color-index-01.html View 1 chunk +23 lines, -0 lines 0 comments Download
A LayoutTests/fast/media/mq-color-index-01-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
A LayoutTests/fast/media/mq-color-index-02.html View 1 chunk +39 lines, -0 lines 0 comments Download
A LayoutTests/fast/media/mq-color-index-02-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/css/MediaFeatureNames.h View 1 3 chunks +3 lines, -0 lines 0 comments Download
M Source/core/css/MediaQueryEvaluator.cpp View 1 3 chunks +22 lines, -3 lines 0 comments Download
M Source/core/css/MediaQueryExp.cpp View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kenneth.r.christiansen
7 years, 7 months ago (2013-05-10 13:45:25 UTC) #1
abarth-chromium
lgtm
7 years, 7 months ago (2013-05-10 16:28:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/15030007/1
7 years, 7 months ago (2013-05-10 16:29:00 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_layout for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_layout&number=1812
7 years, 7 months ago (2013-05-10 22:57:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kenneth.r.christiansen@intel.com/15030007/12001
7 years, 7 months ago (2013-05-10 23:08:52 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-11 00:26:17 UTC) #6
Message was sent while issue was closed.
Change committed as 150156

Powered by Google App Engine
This is Rietveld 408576698