Cleanup: Remove unneeded base/file_util.h includes in chrome.

Cleanup: Remove unneeded base/file_util.h includes in chrome.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200118

[Lei Zhang, 2013-05-13 23:32:22]

thakis: main reviewer - there are some lint fixes as well in files where the
diffstat is not just -1 line.

jln: trivial change in chrome/common/chrome_utility_messages.h

[Nico, 2013-05-14 02:51:47]

lgtm!

The ':' moving is a bit too much cleanup maybe.

To check the file list, I ran

  git grep -l file_util.h > list.txt
  (for f in $(cat list.txt); do if ! grep -q  'file_util::' $f ; then echo $f;
fi; done) > list2.txt

and then diff'd list2.txt with the list of files in this CL. You're not removing
the include from any file that needs it. If you want to do more, you're missing
these files:

chrome/browser/chromeos/extensions/file_manager/file_browser_private_api.cc
chrome/browser/extensions/api/tabs/tabs_api.cc
chrome/browser/google_apis/drive_api_operations_unittest.cc
chrome/browser/media_galleries/fileapi/device_media_async_file_util.h
chrome/browser/media_galleries/fileapi/filtering_file_enumerator.h
chrome/browser/media_galleries/fileapi/itunes/itunes_file_util.cc
chrome/browser/media_galleries/fileapi/itunes/itunes_file_util.h
chrome/browser/media_galleries/fileapi/media_file_system_mount_point_provider.cc
chrome/browser/media_galleries/fileapi/mtp_device_async_delegate.h
chrome/browser/media_galleries/fileapi/native_media_file_util.h
chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.h
chrome/browser/media_galleries/linux/mtp_device_object_enumerator.h
chrome/browser/media_galleries/linux/mtp_device_task_helper.cc
chrome/browser/media_galleries/linux/mtp_device_task_helper.h
chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac.mm
chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.h
chrome/browser/media_galleries/win/mtp_device_object_enumerator.h
chrome/browser/ui/webui/version_handler.cc
chrome/tools/mac_helpers/infoplist_strings_util.mm



(and a ton of files not below chrome/ of course)

https://codereview.chromium.org/15030005/diff/76001/chrome/browser/download/d...
File chrome/browser/download/download_target_determiner_unittest.cc (right):

https://codereview.chromium.org/15030005/diff/76001/chrome/browser/download/d...
chrome/browser/download/download_target_determiner_unittest.cc:128: : public
DownloadTargetDeterminerDelegate {
tsk tsk

https://codereview.chromium.org/15030005/diff/76001/chrome/browser/history/ur...
File chrome/browser/history/url_database_unittest.cc (right):

https://codereview.chromium.org/15030005/diff/76001/chrome/browser/history/ur...
chrome/browser/history/url_database_unittest.cc:133: ASSERT_NE(url_id, 0);
ASSERT_NE(0, url_id)

https://codereview.chromium.org/15030005/diff/76001/chrome/browser/history/ur...
chrome/browser/history/url_database_unittest.cc:172: ASSERT_NE(url_id, 0);
ditto

https://codereview.chromium.org/15030005/diff/76001/chrome/browser/history/ur...
chrome/browser/history/url_database_unittest.cc:234: ASSERT_NE(url_id1, 0);
ditto

https://codereview.chromium.org/15030005/diff/76001/chrome/browser/history/ur...
chrome/browser/history/url_database_unittest.cc:258: ASSERT_NE(url_id2, 0);
ditto

[Lei Zhang, 2013-05-14 03:10:36]

On 2013/05/14 02:51:47, Nico wrote:
> lgtm!
> 
> The ':' moving is a bit too much cleanup maybe.
> 
> To check the file list, I ran
> 
>   git grep -l file_util.h > list.txt
>   (for f in $(cat list.txt); do if ! grep -q  'file_util::' $f ; then echo $f;
> fi; done) > list2.txt
> 
> and then diff'd list2.txt with the list of files in this CL. You're not
removing
> the include from any file that needs it. If you want to do more, you're
missing
> these files:
> 

There's one function in file_util.h that's not in the file_util namespace.
There's also some other non-base file_utils. I made another pass and got a
couple more that either I missed or someone added.

I'm doing these in chunks. There's currently another for base/ and for
contents/.

> (and a ton of files not below chrome/ of course)
> 
>
https://codereview.chromium.org/15030005/diff/76001/chrome/browser/download/d...
> File chrome/browser/download/download_target_determiner_unittest.cc (right):
> 
>
https://codereview.chromium.org/15030005/diff/76001/chrome/browser/download/d...
> chrome/browser/download/download_target_determiner_unittest.cc:128: : public
> DownloadTargetDeterminerDelegate {
> tsk tsk

The cpp linter complains about: "class ReallyLongName :\n    public
AnotherClass", so I try to fix them. 

>
https://codereview.chromium.org/15030005/diff/76001/chrome/browser/history/ur...
> File chrome/browser/history/url_database_unittest.cc (right):
> 
>
https://codereview.chromium.org/15030005/diff/76001/chrome/browser/history/ur...
> chrome/browser/history/url_database_unittest.cc:133: ASSERT_NE(url_id, 0);
> ASSERT_NE(0, url_id)
> 
>
https://codereview.chromium.org/15030005/diff/76001/chrome/browser/history/ur...
> chrome/browser/history/url_database_unittest.cc:172: ASSERT_NE(url_id, 0);
> ditto
> 
>
https://codereview.chromium.org/15030005/diff/76001/chrome/browser/history/ur...
> chrome/browser/history/url_database_unittest.cc:234: ASSERT_NE(url_id1, 0);
> ditto
> 
>
https://codereview.chromium.org/15030005/diff/76001/chrome/browser/history/ur...
> chrome/browser/history/url_database_unittest.cc:258: ASSERT_NE(url_id2, 0);
> ditto

All fixed.

[jln (very slow on Chromium), 2013-05-14 09:01:39]

chrome/common/chrome_utility_messages.h lgtm

[grt (UTC plus 2), 2013-05-14 13:12:36]

chrome/installer lgtm w/ one nit

https://codereview.chromium.org/15030005/diff/78016/chrome/installer/util/cre...
File chrome/installer/util/create_reg_key_work_item.cc (right):

https://codereview.chromium.org/15030005/diff/78016/chrome/installer/util/cre...
chrome/installer/util/create_reg_key_work_item.cc:19: base::FilePath path =
base::FilePath::FromWStringHack(*dir);
#include "base/file_path.h" for this

[Lei Zhang, 2013-05-14 18:21:29]

https://codereview.chromium.org/15030005/diff/78016/chrome/installer/util/cre...
File chrome/installer/util/create_reg_key_work_item.cc (right):

https://codereview.chromium.org/15030005/diff/78016/chrome/installer/util/cre...
chrome/installer/util/create_reg_key_work_item.cc:19: base::FilePath path =
base::FilePath::FromWStringHack(*dir);
On 2013/05/14 13:12:37, grt wrote:
> #include "base/file_path.h" for this

Done.

[commit-bot: I haz the power, 2013-05-14 18:26:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/15030005/113001

[commit-bot: I haz the power, 2013-05-14 19:18:03]

Sorry for I got bad news for ya.
Compile failed with a clobber build on linux_chromeos_clang.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-05-14 20:07:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thestig@chromium.org/15030005/24024

[commit-bot: I haz the power, 2013-05-15 00:26:16]

Change committed as 200118