Issue 15030003: Updated style checker for wtf/file.h includes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15030003: Updated style checker for wtf/file.h includes. (Closed)

Created:
7 years, 7 months ago by alancutter (OOO until 2018)

Modified:
7 years, 7 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, yhirano

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Updated style checker for wtf/file.h includes. The new Blink style is to use "" instead of <> for all #includes pointing inside Source/. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=149866

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	Tools/Scripts/webkitpy/style/checkers/cpp.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py	View	1	1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

abarth-chromium

LGTM, but I bet there are unit tests to update. Did you run test-webkitpy?

7 years, 7 months ago (2013-05-07 07:08:22 UTC) #2

alancutter (OOO until 2018)

On 2013/05/07 07:08:22, abarth wrote: > LGTM, but I bet there are unit tests to ...

7 years, 7 months ago (2013-05-07 07:13:07 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alancutter@chromium.org/15030003/4001

7 years, 7 months ago (2013-05-07 07:13:36 UTC) #4

Message was sent while issue was closed.

Change committed as 149866