Tests updated from Selenium head. Some new tests are failing, added to test_expectations in a separ…

Tests updated from Selenium head. Some new tests are failing, added to test_expectations in a separate patch.

[klm, 2013-05-10 14:17:57]

A couple of issues...

1. I can't figure out how to create a single patch with these java_tests files
and chromedriver/test_expectations. The java_tests are a separate svn checkout.

1. I can't upload the jars and zip:

Not uploading the base file for test-nodeps-srcs.jar because it's too large.
Not uploading the current file for test-nodeps-srcs.jar because it's too large.
Not uploading the base file for test-standalone.jar because it's too large.
Not uploading the current file for test-standalone.jar because it's too large.
Uploading base file for common.zip
Traceback (most recent call last):
...
UnicodeDecodeError: 'utf8' codec can't decode byte 0xce in position 631: invalid
continuation byte

[klm, 2013-05-10 19:34:31]

For reference, the test_expectations patch is
https://chromiumcodereview.appspot.com/14843010/.

[kkania, 2013-05-13 21:32:54]

On 2013/05/10 19:34:31, klm wrote:
> For reference, the test_expectations patch is
> https://chromiumcodereview.appspot.com/14843010/.

Both of these are expected. Send me an email with your stuff. The commit queue
doesn't handle binary files (last time I checked) anyways. You do need to modify
the REAMDE though with the version you build these jars at. Also, try just
uploading patch.diff and the README changes. I can't see your patch.diff
changes, probably because Rietveld was unhappy about your binary files.

[klm, 2013-05-14 20:23:40]

Thanks! Jason Leyba told me last week that he thinks open source Selenium
may get a version tag today, let me check the status of that and update the
tests so they are built at an official Selenium version... You can see the
patch.diff if you click on its filename not on "View" -- it didn't upload
the base file, but you can still see the raw (colored) diff.

Michael


On Mon, May 13, 2013 at 5:32 PM, <kkania@chromium.org> wrote:

> On 2013/05/10 19:34:31, klm wrote:
>
>> For reference, the test_expectations patch is
>>
https://chromiumcodereview.**appspot.com/14843010/<https://chromiumcodereview...
>> .
>>
>
> Both of these are expected. Send me an email with your stuff. The commit
> queue
> doesn't handle binary files (last time I checked) anyways. You do need to
> modify
> the REAMDE though with the version you build these jars at. Also, try just
> uploading patch.diff and the README changes. I can't see your patch.diff
> changes, probably because Rietveld was unhappy about your binary files.
>
>
https://codereview.chromium.**org/15029007/<https://codereview.chromium.org/1...
>

[klm, 2013-05-17 13:18:10]

Just an update: Selenium still has not created a 2.33.0 label, so I'm still
waiting.

Their changelog looks like they are cleaning up tests before labeling a
release, including one change in a logging test (looks like I missed
skipping one testcase with isOldChromedriver). My understanding is the
Selenium tests update to chromium is not burning, and it would be better to
get clean tests from an official label, than to get "almost" clean tests
from head, and all indications are that a label is no more than a few days
away, so I'd rather wait for that, unless there are reasons to update
immediately.

Michael


On Tue, May 14, 2013 at 4:23 PM, Michael Klepikov <klm@google.com> wrote:

> Thanks! Jason Leyba told me last week that he thinks open source Selenium
> may get a version tag today, let me check the status of that and update the
> tests so they are built at an official Selenium version... You can see the
> patch.diff if you click on its filename not on "View" -- it didn't upload
> the base file, but you can still see the raw (colored) diff.
>
> Michael
>
>
> On Mon, May 13, 2013 at 5:32 PM, <kkania@chromium.org> wrote:
>
>> On 2013/05/10 19:34:31, klm wrote:
>>
>>> For reference, the test_expectations patch is
>>>
https://chromiumcodereview.**appspot.com/14843010/<https://chromiumcodereview...
>>> .
>>>
>>
>> Both of these are expected. Send me an email with your stuff. The commit
>> queue
>> doesn't handle binary files (last time I checked) anyways. You do need to
>> modify
>> the REAMDE though with the version you build these jars at. Also, try just
>> uploading patch.diff and the README changes. I can't see your patch.diff
>> changes, probably because Rietveld was unhappy about your binary files.
>>
>>
https://codereview.chromium.**org/15029007/<https://codereview.chromium.org/1...
>>
>
>

[klm, 2013-05-22 16:22:02]

Update tests to Selenium 2.33.0.