Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15027009: Broadcast prerender URLs to all render processes. (Closed)

Created:
7 years, 7 months ago by cbentzel
Modified:
4 years, 8 months ago
CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org, mmenke
Visibility:
Public.

Description

Broadcast prerender URLs to all render processes. Before this change, a render-initiated navigation could only swap to a prerender if the prerender was created via a <link rel="prerender"> element from a RenderView within the same render process. Now that we are experimenting with local-browsing based prerenders, this means that a lot of prerenders may never be used. The prerenders are created in the browser process, and need to be advertised to all render processes. There is a slight risk that an owned render process can spy on some navigations that a user does due to the broadcast. BUG=239180 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200223

Patch Set 1 #

Patch Set 2 : Fix unit_tests #

Patch Set 3 : Include vector #

Patch Set 4 : Remove comment #

Patch Set 5 : More unit tests #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -73 lines) Patch
M chrome/browser/prerender/prerender_contents.h View 2 chunks +0 lines, -6 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 4 chunks +18 lines, -11 lines 0 comments Download
M chrome/browser/prerender/prerender_handle.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/prerender/prerender_handle.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/prerender/prerender_link_manager.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_link_manager.cc View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/common/prerender_messages.h View 1 chunk +5 lines, -2 lines 0 comments Download
M chrome/renderer/prerender/prerender_dispatcher.h View 1 2 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/renderer/prerender/prerender_dispatcher.cc View 4 chunks +14 lines, -17 lines 2 comments Download
M chrome/renderer/prerender/prerender_dispatcher_unittest.cc View 1 2 3 4 3 chunks +47 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (1 generated)
cbentzel
This isn't ready to land yet - but how im planning to implement this
7 years, 7 months ago (2013-05-08 13:06:19 UTC) #1
cbentzel
The way I tested this is I had a local file which looked like: <html> ...
7 years, 7 months ago (2013-05-08 14:09:54 UTC) #2
cbentzel
On 2013/05/08 14:09:54, cbentzel wrote: > The way I tested this is I had a ...
7 years, 7 months ago (2013-05-08 14:10:37 UTC) #3
tburkard
lgtm
7 years, 7 months ago (2013-05-08 18:03:10 UTC) #4
gavinp
lgtm. https://chromiumcodereview.appspot.com/15027009/diff/20001/chrome/renderer/prerender/prerender_dispatcher.cc File chrome/renderer/prerender/prerender_dispatcher.cc (right): https://chromiumcodereview.appspot.com/15027009/diff/20001/chrome/renderer/prerender/prerender_dispatcher.cc#newcode60 chrome/renderer/prerender/prerender_dispatcher.cc:60: void PrerenderDispatcher::OnPrerenderAddAlias(const GURL& alias) { Initially I wanted ...
7 years, 7 months ago (2013-05-13 16:30:27 UTC) #5
cbentzel
https://codereview.chromium.org/15027009/diff/20001/chrome/renderer/prerender/prerender_dispatcher.cc File chrome/renderer/prerender/prerender_dispatcher.cc (right): https://codereview.chromium.org/15027009/diff/20001/chrome/renderer/prerender/prerender_dispatcher.cc#newcode60 chrome/renderer/prerender/prerender_dispatcher.cc:60: void PrerenderDispatcher::OnPrerenderAddAlias(const GURL& alias) { On 2013/05/13 16:30:27, gavinp ...
7 years, 7 months ago (2013-05-13 22:33:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/15027009/20001
7 years, 7 months ago (2013-05-13 22:33:17 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=2737
7 years, 7 months ago (2013-05-13 22:41:04 UTC) #8
cbentzel
+palmer for the prerender_messages.h change
7 years, 7 months ago (2013-05-14 01:14:47 UTC) #9
palmer
IPC security LGTM
7 years, 7 months ago (2013-05-14 21:43:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cbentzel@chromium.org/15027009/20001
7 years, 7 months ago (2013-05-15 00:48:36 UTC) #11
commit-bot: I haz the power
Change committed as 200223
7 years, 7 months ago (2013-05-15 09:50:13 UTC) #12
b.jericena
4 years, 8 months ago (2016-04-01 05:07:59 UTC) #14
Message was sent while issue was closed. 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698