Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(384)

Issue 15026005: Remove unused third_party/WebKit #includes from chrome/browser (Closed)

Created:
7 years, 7 months ago by jamesr
Modified:
7 years, 7 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Remove unused third_party/WebKit #includes from chrome/browser BUG=237267 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198977 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=199314

Patch Set 1 #

Patch Set 2 : without browser_test changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/browser/chrome_net_benchmarking_message_filter.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/ash/window_positioner_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_ash_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/window_sizer/window_sizer_common_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
jamesr
7 years, 7 months ago (2013-05-07 19:48:56 UTC) #1
darin (slow to review)
LGTM
7 years, 7 months ago (2013-05-07 20:10:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/15026005/1
7 years, 7 months ago (2013-05-07 21:27:53 UTC) #3
cpu_(ooo_6.6-7.5)
lgtm
7 years, 7 months ago (2013-05-08 01:09:37 UTC) #4
commit-bot: I haz the power
Commit queue rejected this change because the description was changed between the time the change ...
7 years, 7 months ago (2013-05-08 19:36:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/15026005/1
7 years, 7 months ago (2013-05-08 20:22:02 UTC) #6
commit-bot: I haz the power
Change committed as 198977
7 years, 7 months ago (2013-05-08 20:24:42 UTC) #7
jamesr
On 2013/05/08 20:24:42, I haz the power (commit-bot) wrote: > Change committed as 198977 Reverted ...
7 years, 7 months ago (2013-05-08 22:08:06 UTC) #8
jamesr
Will take another crack with only #include removals, no code changes. The rest will have ...
7 years, 7 months ago (2013-05-08 22:18:30 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/15026005/28001
7 years, 7 months ago (2013-05-09 21:01:32 UTC) #10
commit-bot: I haz the power
7 years, 7 months ago (2013-05-10 00:19:14 UTC) #11
Message was sent while issue was closed.
Change committed as 199314

Powered by Google App Engine
This is Rietveld 408576698