Issue 15025003: Add colors to git cl comments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15025003: Add colors to git cl comments. (Closed)

Created:
7 years, 7 months ago by M-A Ruel

Modified:
7 years, 7 months ago

Reviewers:
iannucci

CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Visibility:
Public.

More Reviews

Description

Add colors to git cl comments. Helps scanning faster. colorma is already slightly used by gclient but wasn't by git-cl yet. Update a unit test to be stricter, it was caught in the cross fire as colorma hooks sys.stdout and stderr. R=iannucci@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=198689

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix import #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -10 lines)			Patch
	M	git_cl.py	View	1	5 chunks	+18 lines, -1 line	0 comments	Download
	M	tests/git_cl_test.py	View		1 chunk	+10 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

iannucci

lgtm https://codereview.chromium.org/15025003/diff/1/git_cl.py File git_cl.py (right): https://codereview.chromium.org/15025003/diff/1/git_cl.py#newcode30 git_cl.py:30: from third_party.colorama import Fore Fore = colorama.Fore ?

7 years, 7 months ago (2013-05-07 01:49:49 UTC) #2

M-A Ruel

I'll commit tomorrow morning so I can revert if any problem comes up. https://codereview.chromium.org/15025003/diff/1/git_cl.py File ...

7 years, 7 months ago (2013-05-07 02:03:58 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/15025003/5001

7 years, 7 months ago (2013-05-07 12:40:34 UTC) #4

Message was sent while issue was closed.

Change committed as 198689

Expand Messages | Collapse Messages