Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 15024007: Eliminate BrowserProcess dependency from sign-in production code. (Closed)

Created:
7 years, 7 months ago by Jói
Modified:
7 years, 7 months ago
CC:
chromium-reviews, Raghu Simha, haitaol1, erikwright+watch_chromium.org, akalin, tim (not reviewing)
Visibility:
Public.

Description

Eliminate BrowserProcess dependency from sign-in production code. TBR=atwilson@chromium.org,phajdan.jr@chromium.org BUG=233552 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200931

Patch Set 1 #

Patch Set 2 : Fix tests. #

Patch Set 3 : Fix CrOS build. #

Patch Set 4 : Merge LKGR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -63 lines) Patch
M base/prefs/pref_change_registrar.h View 1 chunk +1 line, -0 lines 0 comments Download
M base/prefs/pref_change_registrar.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/policy/cloud/user_cloud_policy_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/DEPS View 3 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_global_error_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/signin/signin_manager_base.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/signin_manager_base.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/signin/signin_manager_cookie_helper.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/signin/signin_manager_factory.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/signin/signin_manager_unittest.cc View 1 22 chunks +26 lines, -26 lines 0 comments Download
M chrome/browser/signin/signin_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/sync/sync_ui_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_setup_handler_unittest.cc View 1 2 3 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/base/chrome_render_view_host_test_harness.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jói
7 years, 7 months ago (2013-05-15 23:11:23 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm Curious Joi: I guess to get those lists in the DEPS file to zero, ...
7 years, 7 months ago (2013-05-17 17:43:43 UTC) #2
Jói
The ones I've identified so far as not moving are listed at the bottom of ...
7 years, 7 months ago (2013-05-17 17:50:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/15024007/18001
7 years, 7 months ago (2013-05-17 18:02:46 UTC) #4
Jói
TBR=atwilson@chromium.org,phajdan.jr@chromium.org for trivial usage updates. Cheers, Jói
7 years, 7 months ago (2013-05-17 18:09:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/15024007/18001
7 years, 7 months ago (2013-05-17 18:10:51 UTC) #6
Paweł Hajdan Jr.
chrome/test LGTM
7 years, 7 months ago (2013-05-17 22:02:49 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-18 00:07:09 UTC) #8
Message was sent while issue was closed.
Change committed as 200931

Powered by Google App Engine
This is Rietveld 408576698