Chromium Code Reviews
Help | Chromium Project | Sign in
(246)

Issue 15024007: Eliminate BrowserProcess dependency from sign-in production code. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months, 1 week ago by Jói
Modified:
11 months, 1 week ago
CC:
chromium-reviews_chromium.org, Raghu Simha, haitaol1, erikwright+watch_chromium.org, akalin, timsteele
Visibility:
Public.

Description

Eliminate BrowserProcess dependency from sign-in production code.

TBR=atwilson@chromium.org,phajdan.jr@chromium.org
BUG=233552
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200931

Patch Set 1 #

Patch Set 2 : Fix tests. #

Patch Set 3 : Fix CrOS build. #

Patch Set 4 : Merge LKGR #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -63 lines) Lint Patch
M base/prefs/pref_change_registrar.h View 1 chunk +1 line, -0 lines 0 comments 0 errors Download
M base/prefs/pref_change_registrar.cc View 1 chunk +4 lines, -0 lines 0 comments 1 errors Download
M chrome/browser/policy/cloud/user_cloud_policy_store_unittest.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M chrome/browser/signin/DEPS View 3 chunks +5 lines, -2 lines 0 comments ? errors Download
M chrome/browser/signin/signin_global_error_unittest.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M chrome/browser/signin/signin_manager.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M chrome/browser/signin/signin_manager.cc View 3 chunks +3 lines, -5 lines 0 comments 0 errors Download
M chrome/browser/signin/signin_manager_base.h View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M chrome/browser/signin/signin_manager_base.cc View 2 chunks +1 line, -2 lines 0 comments 0 errors Download
M chrome/browser/signin/signin_manager_cookie_helper.cc View 1 chunk +0 lines, -1 line 0 comments 0 errors Download
M chrome/browser/signin/signin_manager_factory.cc View 2 chunks +2 lines, -1 line 0 comments 0 errors Download
M chrome/browser/signin/signin_manager_unittest.cc View 1 22 chunks +26 lines, -26 lines 0 comments 0 errors Download
M chrome/browser/signin/signin_tracker_unittest.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M chrome/browser/sync/profile_sync_service_startup_unittest.cc View 11 chunks +11 lines, -11 lines 0 comments 0 errors Download
M chrome/browser/sync/sync_ui_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M chrome/browser/ui/sync/one_click_signin_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments 0 errors Download
M chrome/browser/ui/webui/sync_setup_handler_unittest.cc View 1 2 3 5 chunks +5 lines, -5 lines 0 comments 0 errors Download
M chrome/test/base/chrome_render_view_host_test_harness.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments 0 errors Download
Commit:

Messages

Total messages: 8
Jói
11 months, 1 week ago #1
Roger Tawa
lgtm Curious Joi: I guess to get those lists in the DEPS file to zero, ...
11 months, 1 week ago #2
Jói
The ones I've identified so far as not moving are listed at the bottom of ...
11 months, 1 week ago #3
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/15024007/18001
11 months, 1 week ago #4
Jói
TBR=atwilson@chromium.org,phajdan.jr@chromium.org for trivial usage updates. Cheers, Jói
11 months, 1 week ago #5
I haz the power (commit-bot)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joi@chromium.org/15024007/18001
11 months, 1 week ago #6
Paweł Hajdan Jr.
chrome/test LGTM
11 months, 1 week ago #7
I haz the power (commit-bot)
11 months, 1 week ago #8
Message was sent while issue was closed.
Change committed as 200931
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6