Issue 15023016: Merged r14584, r14596 into 3.18 branch.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15023016: Merged r14584, r14596 into 3.18 branch. (Closed)

Created:
7 years, 7 months ago by ulan

Modified:
7 years, 7 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/3.18

Visibility:
Public.

More Reviews

Description

Merged r14584, r14596 into 3.18 branch. Do not change environment between simulate and scope with no observable side-effects in HandlePropertyAssignment. Fix environment in HOptimizedGraphBuilder::VisitCountOperation. Follow-up for r14584. BUG=v8:2671, v8:2671 R=svenpanne@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=14633

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -13 lines)			Patch
M	src/hydrogen.cc	View	3 chunks	+9 lines, -8 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	test/mjsunit/regress/regress-2671.js	View	1 chunk	+11 lines, -2 lines	0 comments	Download
A +	test/mjsunit/regress/regress-2671-1.js	View	1 chunk	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

7 years, 7 months ago (2013-05-13 09:39:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r14633 (presubmit successful).

Expand Messages | Collapse Messages