|
|
Created:
7 years, 7 months ago by dshwang Modified:
7 years, 7 months ago CC:
blink-reviews, eae+blinkwatch Base URL:
https://chromium.googlesource.com/chromium/blink.git@flaky Visibility:
Public. |
DescriptionMake the resize-events test not flaky.
resize-events calls setTimeout many time in turn after calling
testRunner.waitUntilDone(). It seems to cause test timed out. So this patch
changes resize-events to use setTimeout one time to avoid flaky.
BUG=239483
TEST=fast/events/resize-events.html
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151154
Patch Set 1 #Patch Set 2 : Preserve previous behavior #Patch Set 3 : patch to land: rebase to upstream #Patch Set 4 : patch to land: rebase to 1 sec ago upstream #
Messages
Total messages: 24 (0 generated)
On 2013/05/10 10:08:35, dshwang wrote: I know that this patch is just workaround. So I file Issue 239759 to fix the origin of flakiness.
I submitted this workaround instead of fixing the origin evil, because I need this test for Issue 14766010 (https://codereview.chromium.org/14766010/)
Hi! could you review please?
Are you sure this tests the same thing now? Previously it yielded to the event loop repeatedly probably causing layouts and style recalcs, not you only do that once. You might need an offsetLeft or something in that loop to make this test the same thing.
On 2013/05/13 05:50:59, esprehn wrote: > Are you sure this tests the same thing now? Previously it yielded to the event > loop repeatedly probably causing layouts and style recalcs, not you only do that > once. You might need an offsetLeft or something in that loop to make this test > the same thing. That's smart question. I submitted 2nd patch to preserve the purpose of this test. The goal of this patch reduce the number of calling setTimeout as soon as possible: from 10 to 2. The purpose of this test is to check if resize evnet is emitted in such cases: 1. during loading 2. between the first layout and creating main frame scrollbar. Let's focus on #2. To check #2, we need only two times to call setTimeout: after the first layout and after creating main frame scrollbar. This test creates and append many divs to create main frame scrollbar. Currently, this test calls setTimeout every time to create div, but it is not necessary. This change preserves the purpose of this test although the behavior is changed.
Hi! could you review please?
ping
lgtm
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/15023009/5001
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file LayoutTests/TestExpectations Hunk #1 FAILED at 53. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/TestExpectations.rej Patch: LayoutTests/TestExpectations Index: LayoutTests/TestExpectations diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations index e062a73b810cbeb28f5bc4dde6b0dc81258bb4a6..df2bca7fd4a91fc0c104ce7ed538f3c0e7387259 100644 --- a/LayoutTests/TestExpectations +++ b/LayoutTests/TestExpectations @@ -53,7 +53,6 @@ webkit.org/b/113129 [ Win7 Debug ] inspector/styles/edit-inspector-stylesheet.ht webkit.org/b/82954 svg/hixie/perf/007.xml [ Slow ] crbug.com/239465 [ Mac ] fast/canvas/webgl/premultiplyalpha-test.html [ Pass Failure ] crbug.com/239465 [ Win ] fast/canvas/webgl/premultiplyalpha-test.html [ Pass Crash Timeout ] -crbug.com/239483 [ Release ] fast/events/resize-events.html [ Pass Timeout ] # These tests started being slow when we switched to DRT. webkit.org/b/90488 [ Debug ] inspector [ Slow ]
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/15023009/14001
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file LayoutTests/TestExpectations Hunk #1 FAILED at 52. 1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/TestExpectations.rej Patch: LayoutTests/TestExpectations Index: LayoutTests/TestExpectations diff --git a/LayoutTests/TestExpectations b/LayoutTests/TestExpectations index b75277903ab69eed03b09f4d7a1ae30c6203c798..5cd423dc0d46e62d669e9a08f920a0140627ac69 100644 --- a/LayoutTests/TestExpectations +++ b/LayoutTests/TestExpectations @@ -52,7 +52,6 @@ webkit.org/b/111640 [ Mac Win ] fast/dom/Window/window-special-properties.html [ webkit.org/b/82954 svg/hixie/perf/007.xml [ Slow ] crbug.com/239465 [ Mac ] fast/canvas/webgl/premultiplyalpha-test.html [ Pass Failure ] crbug.com/239465 [ Win ] fast/canvas/webgl/premultiplyalpha-test.html [ Pass Crash Timeout ] -crbug.com/239483 [ Release ] fast/events/resize-events.html [ Pass Timeout ] crbug.com/239794 [ Win Debug ] inspector/debugger/pause-in-internal-script.html [ Pass Timeout ] # Sometimes the output includes an empty line, sometimes it doesn't. Flake.
On 2013/05/24 08:40:29, eseidel wrote: > lgtm thx for lgtm :)
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/15023009/19003
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/15023009/19003
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/15023009/19003
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/15023009/19003
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layo...
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/15023009/19003
Message was sent while issue was closed.
Change committed as 151154 |