Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 15023009: Make the resize-events test not flaky. (Closed)

Created:
7 years, 7 months ago by dshwang
Modified:
7 years, 7 months ago
CC:
blink-reviews, eae+blinkwatch
Base URL:
https://chromium.googlesource.com/chromium/blink.git@flaky
Visibility:
Public.

Description

Make the resize-events test not flaky. resize-events calls setTimeout many time in turn after calling testRunner.waitUntilDone(). It seems to cause test timed out. So this patch changes resize-events to use setTimeout one time to avoid flaky. BUG=239483 TEST=fast/events/resize-events.html Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=151154

Patch Set 1 #

Patch Set 2 : Preserve previous behavior #

Patch Set 3 : patch to land: rebase to upstream #

Patch Set 4 : patch to land: rebase to 1 sec ago upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M LayoutTests/TestExpectations View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/events/resize-events.html View 1 2 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 24 (0 generated)
dshwang
7 years, 7 months ago (2013-05-10 10:08:35 UTC) #1
dshwang
On 2013/05/10 10:08:35, dshwang wrote: I know that this patch is just workaround. So I ...
7 years, 7 months ago (2013-05-10 10:16:42 UTC) #2
dshwang
I submitted this workaround instead of fixing the origin evil, because I need this test ...
7 years, 7 months ago (2013-05-10 10:22:29 UTC) #3
dshwang
Hi! could you review please?
7 years, 7 months ago (2013-05-13 05:29:05 UTC) #4
esprehn
Are you sure this tests the same thing now? Previously it yielded to the event ...
7 years, 7 months ago (2013-05-13 05:50:59 UTC) #5
dshwang
On 2013/05/13 05:50:59, esprehn wrote: > Are you sure this tests the same thing now? ...
7 years, 7 months ago (2013-05-13 14:22:24 UTC) #6
dshwang
Hi! could you review please?
7 years, 7 months ago (2013-05-17 13:54:28 UTC) #7
dshwang
ping
7 years, 7 months ago (2013-05-23 10:53:27 UTC) #8
eseidel
lgtm
7 years, 7 months ago (2013-05-24 08:40:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/15023009/5001
7 years, 7 months ago (2013-05-24 08:40:40 UTC) #10
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-24 08:40:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/15023009/14001
7 years, 7 months ago (2013-05-24 11:22:49 UTC) #12
commit-bot: I haz the power
Failed to apply patch for LayoutTests/TestExpectations: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
7 years, 7 months ago (2013-05-24 11:22:50 UTC) #13
dshwang
On 2013/05/24 08:40:29, eseidel wrote: > lgtm thx for lgtm :)
7 years, 7 months ago (2013-05-24 11:23:14 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/15023009/19003
7 years, 7 months ago (2013-05-24 11:27:48 UTC) #15
commit-bot: I haz the power
Retried try job too often on mac_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_layout_rel&number=7328
7 years, 7 months ago (2013-05-24 12:54:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/15023009/19003
7 years, 7 months ago (2013-05-24 14:39:32 UTC) #17
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10066
7 years, 7 months ago (2013-05-24 15:42:25 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/15023009/19003
7 years, 7 months ago (2013-05-24 16:15:24 UTC) #19
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10107
7 years, 7 months ago (2013-05-24 17:33:07 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/15023009/19003
7 years, 7 months ago (2013-05-24 19:03:59 UTC) #21
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=10160
7 years, 7 months ago (2013-05-24 20:05:48 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dongseong.hwang@intel.com/15023009/19003
7 years, 7 months ago (2013-05-25 14:15:49 UTC) #23
commit-bot: I haz the power
7 years, 7 months ago (2013-05-25 14:50:24 UTC) #24
Message was sent while issue was closed.
Change committed as 151154

Powered by Google App Engine
This is Rietveld 408576698