Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 15021014: Crash in ResourceLoader::releaseResources(). (Closed)

Created:
7 years, 7 months ago by Nate Chapin
Modified:
7 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eae+blinkwatch, gavinp+loader_chromium.org
Visibility:
Public.

Description

Crash in ResourceLoader::releaseResources(). We are sometimes giving RequestCountTracker the wrong CachedResourceLoader when starting a resource load. BUG=240054 TEST=none, the known repro is quite flaky Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150446

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M Source/core/loader/ResourceLoader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/loader/ResourceLoader.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/core/loader/cache/CachedResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/cache/CachedResourceLoader.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Nate Chapin
7 years, 7 months ago (2013-05-14 21:22:51 UTC) #1
abarth-chromium
lgtm
7 years, 7 months ago (2013-05-14 21:32:38 UTC) #2
abarth-chromium
It's too bad we don't have a test for this CL. It's the kind of ...
7 years, 7 months ago (2013-05-14 21:32:58 UTC) #3
Nate Chapin
On 2013/05/14 21:32:58, abarth wrote: > It's too bad we don't have a test for ...
7 years, 7 months ago (2013-05-14 21:41:54 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/15021014/1
7 years, 7 months ago (2013-05-14 21:41:54 UTC) #5
commit-bot: I haz the power
Retried try job too often on linux_layout_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_layout_rel&number=7911
7 years, 7 months ago (2013-05-14 22:35:19 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/15021014/1
7 years, 7 months ago (2013-05-15 16:28:05 UTC) #7
commit-bot: I haz the power
7 years, 7 months ago (2013-05-15 17:42:02 UTC) #8
Message was sent while issue was closed.
Change committed as 150446

Powered by Google App Engine
This is Rietveld 408576698