Issue 15017006: Move test for enabling/disabling It2Me Share button

Issue 15017006: Move test for enabling/disabling It2Me Share button (Closed)

Created:
7 years, 7 months ago by Lambros

Modified:
7 years, 7 months ago

Reviewers:
Jamie

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move test for enabling/disabling It2Me Share button Previously, this test was based on whether the Me2Me host plugin was loaded. But if Native Messaging is supported, this NPAPI instance will not get loaded, so the Share button test should not depend on it. BUG=173509 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198812

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix nit #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -19 lines)			Patch
M	remoting/webapp/host_controller.js	View		3 chunks	+0 lines, -15 lines	0 comments	Download
M	remoting/webapp/main.html	View		2 chunks	+1 line, -2 lines	0 comments	Download
M	remoting/webapp/remoting.js	View	1	1 chunk	+16 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Jamie

lgtm https://codereview.chromium.org/15017006/diff/1/remoting/webapp/remoting.js File remoting/webapp/remoting.js (right): https://codereview.chromium.org/15017006/diff/1/remoting/webapp/remoting.js#newcode132 remoting/webapp/remoting.js:132: function isIt2MeSupported_() { Nit: IT should be capitalized.

7 years, 7 months ago (2013-05-07 19:39:23 UTC) #2

Lambros

https://codereview.chromium.org/15017006/diff/1/remoting/webapp/remoting.js File remoting/webapp/remoting.js (right): https://codereview.chromium.org/15017006/diff/1/remoting/webapp/remoting.js#newcode132 remoting/webapp/remoting.js:132: function isIt2MeSupported_() { On 2013/05/07 19:39:23, Jamie wrote: > ...

7 years, 7 months ago (2013-05-07 21:59:32 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lambroslambrou@chromium.org/15017006/5001

7 years, 7 months ago (2013-05-07 22:02:29 UTC) #4

Message was sent while issue was closed.

Change committed as 198812

Expand Messages | Collapse Messages