Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Side by Side Diff: Source/WebKit/chromium/public/WebFrame.h

Issue 15017002: WebFrame::selectRange and moveCaret should behave like mouse selection (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Address comment Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | Source/WebKit/chromium/src/WebFrameImpl.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 438 matching lines...) Expand 10 before | Expand all | Expand 10 after
449 virtual WebRange selectionRange() const = 0; 449 virtual WebRange selectionRange() const = 0;
450 450
451 virtual WebString selectionAsText() const = 0; 451 virtual WebString selectionAsText() const = 0;
452 virtual WebString selectionAsMarkup() const = 0; 452 virtual WebString selectionAsMarkup() const = 0;
453 453
454 // Expands the selection to a word around the caret and returns 454 // Expands the selection to a word around the caret and returns
455 // true. Does nothing and returns false if there is no caret or 455 // true. Does nothing and returns false if there is no caret or
456 // there is ranged selection. 456 // there is ranged selection.
457 virtual bool selectWordAroundCaret() = 0; 457 virtual bool selectWordAroundCaret() = 0;
458 458
459 // Select a range of text, as if by drag-selecting from base to extent 459 // DEPRECATED: Use moveRangeSelection/moveCaretSelection.
460 // with character granularity.
461 virtual void selectRange(const WebPoint& base, const WebPoint& extent) = 0; 460 virtual void selectRange(const WebPoint& base, const WebPoint& extent) = 0;
461 virtual void moveCaretSelectionTowardsWindowPoint(const WebPoint&) = 0;
462 462
463 virtual void selectRange(const WebRange&) = 0; 463 virtual void selectRange(const WebRange&) = 0;
464 464
465 virtual void moveCaretSelectionTowardsWindowPoint(const WebPoint&) = 0; 465 // Move the current selection to the provided window point/points. If the
466 // current selection is editable, the new selection will be restricted to
467 // the root editable element.
468 virtual void moveRangeSelection(const WebPoint& base, const WebPoint& extent ) = 0;
469 virtual void moveCaretSelection(const WebPoint&) = 0;
466 470
467 // Printing ------------------------------------------------------------ 471 // Printing ------------------------------------------------------------
468 472
469 // Reformats the WebFrame for printing. WebPrintParams specifies the printab le 473 // Reformats the WebFrame for printing. WebPrintParams specifies the printab le
470 // content size, paper size, printable area size, printer DPI and print 474 // content size, paper size, printable area size, printer DPI and print
471 // scaling option. If constrainToNode node is specified, then only the given node 475 // scaling option. If constrainToNode node is specified, then only the given node
472 // is printed (for now only plugins are supported), instead of the entire fr ame. 476 // is printed (for now only plugins are supported), instead of the entire fr ame.
473 // Returns the number of pages that can be printed at the given 477 // Returns the number of pages that can be printed at the given
474 // page size. The out param useBrowserOverlays specifies whether the browser 478 // page size. The out param useBrowserOverlays specifies whether the browser
475 // process should use its overlays (header, footer, margins etc) or whether 479 // process should use its overlays (header, footer, margins etc) or whether
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
656 // text form. This is used only by layout tests. 660 // text form. This is used only by layout tests.
657 virtual WebString layerTreeAsText(bool showDebugInfo = false) const = 0; 661 virtual WebString layerTreeAsText(bool showDebugInfo = false) const = 0;
658 662
659 protected: 663 protected:
660 ~WebFrame() { } 664 ~WebFrame() { }
661 }; 665 };
662 666
663 } // namespace WebKit 667 } // namespace WebKit
664 668
665 #endif 669 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/WebKit/chromium/src/WebFrameImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698