Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: content/browser/download/download_item_impl.cc

Issue 15011006: Remove DownloadItem::GetUserVerifiedFilePath() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Merge with r201294 Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/download/download_item_impl.cc
diff --git a/content/browser/download/download_item_impl.cc b/content/browser/download/download_item_impl.cc
index 27c170796605127ddb40b24c0507a9dbc4d82c06..6f06e3252d6d50b2bc89f8cd68d821edf547cb3b 100644
--- a/content/browser/download/download_item_impl.cc
+++ b/content/browser/download/download_item_impl.cc
@@ -594,13 +594,6 @@ const base::FilePath& DownloadItemImpl::GetForcedFilePath() const {
return forced_file_path_;
}
-// TODO(asanka): Get rid of GetUserVerifiedFilePath(). http://crbug.com/134237.
-base::FilePath DownloadItemImpl::GetUserVerifiedFilePath() const {
- return (IsDangerous() ||
- danger_type_ == DOWNLOAD_DANGER_TYPE_USER_VALIDATED) ?
- GetFullPath() : GetTargetFilePath();
-}
-
base::FilePath DownloadItemImpl::GetFileNameToReportUser() const {
if (!display_name_.empty())
return display_name_;
@@ -705,7 +698,7 @@ bool DownloadItemImpl::CanOpenDownload() {
}
bool DownloadItemImpl::ShouldOpenFileBasedOnExtension() {
- return delegate_->ShouldOpenFileBasedOnExtension(GetUserVerifiedFilePath());
+ return delegate_->ShouldOpenFileBasedOnExtension(GetTargetFilePath());
}
bool DownloadItemImpl::GetOpenWhenComplete() const {
« no previous file with comments | « content/browser/download/download_item_impl.h ('k') | content/browser/download/download_manager_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698