Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1803)

Unified Diff: chrome/common/extensions/docs/server2/appengine_url_fetcher.py

Issue 15009006: Docserver: refactor Servlet, ObjectStore, and ServerInstance architecture to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cduvall, redirect fix Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/docs/server2/appengine_url_fetcher.py
diff --git a/chrome/common/extensions/docs/server2/appengine_url_fetcher.py b/chrome/common/extensions/docs/server2/appengine_url_fetcher.py
index e38f08aad9b28b1edd14a565b8cac6e674f24e29..e9c9991a0f56dff10c8cf95f397fa6ae85453f05 100644
--- a/chrome/common/extensions/docs/server2/appengine_url_fetcher.py
+++ b/chrome/common/extensions/docs/server2/appengine_url_fetcher.py
@@ -31,21 +31,15 @@ class AppEngineUrlFetcher(object):
def Fetch(self, url, username=None, password=None):
"""Fetches a file synchronously.
"""
- headers = _MakeHeaders(username, password)
if self._base_path is not None:
- return urlfetch.fetch('%s/%s' % (self._base_path, url), headers=headers)
- else:
- return urlfetch.fetch(url, headers={ 'Cache-Control': 'max-age=0' })
+ url = '%s/%s' % (self._base_path, url)
+ return urlfetch.fetch(url, headers=_MakeHeaders(username, password))
def FetchAsync(self, url, username=None, password=None):
"""Fetches a file asynchronously, and returns a Future with the result.
"""
- rpc = urlfetch.create_rpc()
- headers = _MakeHeaders(username, password)
if self._base_path is not None:
- urlfetch.make_fetch_call(rpc,
- '%s/%s' % (self._base_path, url),
- headers=headers)
- else:
- urlfetch.make_fetch_call(rpc, url, headers=headers)
+ url = '%s/%s' % (self._base_path, url)
+ rpc = urlfetch.create_rpc()
+ urlfetch.make_fetch_call(rpc, url, headers=_MakeHeaders(username, password))
return Future(delegate=_AsyncFetchDelegate(rpc))

Powered by Google App Engine
This is Rietveld 408576698