Issue 15009005: Fix blue flashes on Mac

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 15009005: Fix blue flashes on Mac (Closed)

Created:
7 years, 7 months ago by ccameron

Modified:
7 years, 7 months ago

Reviewers:
greggman

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fix blue flashes on Mac Set the GL framebuffer before clearing it in GLES2DecoderImpl initialization. Otherwise, other tabs' IOSurfaces will be cleared by this call, and the desired target for the clear won't be cleared. BUG=238069 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=198769

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -8 lines)			Patch
	M	gpu/command_buffer/service/gles2_cmd_decoder.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
	M	gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.cc	View		2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/15009005/1

7 years, 7 months ago (2013-05-07 17:43:34 UTC) #4

commit-bot: I haz the power

Retried try job too often on linux_rel for step(s) browser_tests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&number=125046

7 years, 7 months ago (2013-05-07 18:06:32 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ccameron@chromium.org/15009005/1

7 years, 7 months ago (2013-05-07 18:34:38 UTC) #6

Message was sent while issue was closed.

Change committed as 198769

Expand Messages | Collapse Messages