webkit/glue/cpp_bound_class.h - Issue 15007012: Track NPObject ownership by the originating plugins' NPP identifier. [2/3] (Chrome)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webkit/glue/cpp_bound_class.h

Issue 15007012: Track NPObject ownership by the originating plugins' NPP identifier. [2/3] (Chrome) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix teardown of BrowserPlugins that were never initialize()d. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: webkit/glue/cpp_bound_class.h

diff --git a/webkit/glue/cpp_bound_class.h b/webkit/glue/cpp_bound_class.h

index 3d7427d8279c0f394275399103e6115102696b83..d62e2effb586b8d775bca6dd80b70ca91cb83581 100644

--- a/webkit/glue/cpp_bound_class.h

+++ b/webkit/glue/cpp_bound_class.h

@@ -133,9 +133,8 @@ class WEBKIT_GLUE_EXPORT CppBoundClass {

// reference to this object, and it is released on deletion.

CppVariant self_variant_;

- // True if our np_object has been bound to a WebFrame, in which case it must

- // be unregistered with V8 when we delete it.

- bool bound_to_frame_;

+ // Dummy NPP to use to register as owner for NPObjects.

+ scoped_ptr<NPP_t> npp_;

DISALLOW_COPY_AND_ASSIGN(CppBoundClass);

};

« no previous file with comments | « content/renderer/webplugin_delegate_proxy.cc ('k') | webkit/glue/cpp_bound_class.cc » ('j') | no next file with comments »