content/renderer/browser_plugin/browser_plugin_bindings.cc - Issue 15007012: Track NPObject ownership by the originating plugins' NPP identifier. [2/3] (Chrome)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/browser_plugin/browser_plugin_bindings.cc

Issue 15007012: Track NPObject ownership by the originating plugins' NPP identifier. [2/3] (Chrome) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix teardown of BrowserPlugins that were never initialize()d. Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/browser_plugin/browser_plugin_bindings.cc

diff --git a/content/renderer/browser_plugin/browser_plugin_bindings.cc b/content/renderer/browser_plugin/browser_plugin_bindings.cc

index 9ded3f98abce3db0def129da0396ab3dfabe919a..7857ed586729e0e645879096ad9db3ce91cbfcba 100644

--- a/content/renderer/browser_plugin/browser_plugin_bindings.cc

+++ b/content/renderer/browser_plugin/browser_plugin_bindings.cc

@@ -817,7 +817,8 @@ BrowserPluginBindings::BrowserPluginBindings(BrowserPlugin* instance)

np_object_(NULL),

weak_ptr_factory_(this) {

NPObject* obj =

- WebBindings::createObject(NULL, &browser_plugin_message_class);

+ WebBindings::createObject(instance->pluginNPP(),

+ &browser_plugin_message_class);

np_object_ = static_cast<BrowserPluginBindings::BrowserPluginNPObject*>(obj);

np_object_->message_channel = weak_ptr_factory_.GetWeakPtr();

« no previous file with comments | « content/renderer/browser_plugin/browser_plugin.cc ('k') | content/renderer/webplugin_delegate_proxy.h » ('j') | no next file with comments »