Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 15006004: Correct scroll offset range for WebFrame in AutomationRendererHelper (Closed)

Created:
7 years, 7 months ago by trchen
Modified:
7 years, 7 months ago
CC:
chromium-reviews, Zhenyao Mo, jamesr, Julien - ping for review
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Correct scroll offset range for WebFrame in AutomationRendererHelper This patch needs to be landed at the same time as https://chromiumcodereview.appspot.com/14703004/ Since WebFrame now uses the non-shifted(ranges [minPos, maxPos]) scroll offset. BUG=232063 TEST=AutomationRendererHelperTest.RTLSnapshot R=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=200990

Patch Set 1 #

Patch Set 2 : re-enable disabled test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -6 lines) Patch
M chrome/renderer/automation/automation_renderer_helper.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M chrome/renderer/automation/automation_renderer_helper_browsertest.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
trchen
Hello Darin, Do you have time to look at this patch? This patch updates chromium ...
7 years, 7 months ago (2013-05-10 23:27:19 UTC) #1
darin (slow to review)
LGTM
7 years, 7 months ago (2013-05-10 23:36:37 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/15006004/4001
7 years, 7 months ago (2013-05-16 22:03:26 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=150210
7 years, 7 months ago (2013-05-17 10:01:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/trchen@chromium.org/15006004/4001
7 years, 7 months ago (2013-05-17 21:54:07 UTC) #5
commit-bot: I haz the power
7 years, 7 months ago (2013-05-18 09:40:45 UTC) #6
Message was sent while issue was closed.
Change committed as 200990

Powered by Google App Engine
This is Rietveld 408576698