Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 1500433002: Add User service. (Closed)

Created:
5 years ago by iannucci
Modified:
5 years ago
Reviewers:
dnj, Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@inner_ctx
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Add User service. Doesn't add a memory implementation... it's easy enough to mock directly in the test and doesn't have any complex systemic behaviors (that I know of) that are necessary for a single mock implementation. R=dnj@chromium.org, vadimsh@chromium.org BUG=https://github.com/luci/gae/issues/19 Committed: https://github.com/luci/gae/commit/9cd6de3742e751baf21302e296f74e765935a7f2

Patch Set 1 #

Total comments: 4

Patch Set 2 : method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -3 lines) Patch
M impl/dummy/dummy.go View 1 3 chunks +24 lines, -2 lines 0 comments Download
M impl/dummy/dummy_test.go View 2 chunks +10 lines, -0 lines 0 comments Download
M impl/prod/context.go View 1 chunk +1 line, -1 line 0 comments Download
A impl/prod/user.go View 1 chunk +55 lines, -0 lines 0 comments Download
A service/user/context.go View 1 chunk +39 lines, -0 lines 0 comments Download
A service/user/interface.go View 1 chunk +19 lines, -0 lines 0 comments Download
A service/user/user.go View 1 chunk +23 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
iannucci
5 years ago (2015-12-03 00:12:04 UTC) #1
Vadim Sh.
lgtm https://codereview.chromium.org/1500433002/diff/1/impl/dummy/dummy.go File impl/dummy/dummy.go (right): https://codereview.chromium.org/1500433002/diff/1/impl/dummy/dummy.go#newcode181 impl/dummy/dummy.go:181: // Every methog panics with a message containing ...
5 years ago (2015-12-03 00:55:56 UTC) #2
iannucci
https://codereview.chromium.org/1500433002/diff/1/impl/dummy/dummy.go File impl/dummy/dummy.go (right): https://codereview.chromium.org/1500433002/diff/1/impl/dummy/dummy.go#newcode181 impl/dummy/dummy.go:181: // Every methog panics with a message containing the ...
5 years ago (2015-12-03 01:00:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1500433002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1500433002/20001
5 years ago (2015-12-03 01:10:10 UTC) #6
commit-bot: I haz the power
5 years ago (2015-12-03 01:14:38 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/gae/commit/9cd6de3742e751baf21302e296f74e765935a7f2

Powered by Google App Engine
This is Rietveld 408576698