Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: webkit/plugins/ppapi/ppapi_plugin_instance.cc

Issue 15004024: Only use skia::RefPtr for refcounting (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Comment changes, SharePtr Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/plugins/ppapi/ppapi_plugin_instance.h ('k') | webkit/renderer/compositor_bindings/web_layer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/plugins/ppapi/ppapi_plugin_instance.cc
diff --git a/webkit/plugins/ppapi/ppapi_plugin_instance.cc b/webkit/plugins/ppapi/ppapi_plugin_instance.cc
index 0bd76f4a3cefc7e6df2cf9e990664d696fdb750b..9368e294d9cb92ddb5de4f20daa88ed75e2efb28 100644
--- a/webkit/plugins/ppapi/ppapi_plugin_instance.cc
+++ b/webkit/plugins/ppapi/ppapi_plugin_instance.cc
@@ -1399,7 +1399,7 @@ int PluginInstance::PrintBegin(const WebPrintParams& print_params) {
if (!num_pages)
return 0;
current_print_settings_ = print_settings;
- canvas_ = NULL;
+ canvas_.clear();
ranges_.clear();
return num_pages;
}
@@ -1417,7 +1417,7 @@ bool PluginInstance::PrintPage(int page_number, WebKit::WebCanvas* canvas) {
#endif
if (save_for_later) {
ranges_.push_back(page_range);
- canvas_ = canvas;
+ canvas_ = skia::SharePtr(canvas);
return true;
} else {
return PrintPageHelper(&page_range, 1, canvas);
@@ -1456,7 +1456,7 @@ void PluginInstance::PrintEnd() {
scoped_refptr<PluginInstance> ref(this);
if (!ranges_.empty())
PrintPageHelper(&(ranges_.front()), ranges_.size(), canvas_.get());
- canvas_ = NULL;
+ canvas_.clear();
ranges_.clear();
DCHECK(plugin_print_interface_);
« no previous file with comments | « webkit/plugins/ppapi/ppapi_plugin_instance.h ('k') | webkit/renderer/compositor_bindings/web_layer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698