Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15004016: Remove VTable-based binding integrity now that ScriptWrappable-based binding integrity is implement… (Closed)

Created:
7 years, 7 months ago by Tom Sepez
Modified:
7 years, 7 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, aandrey+blink_chromium.org, caseq+blink_chromium.org, chromiumbugtracker_adobe.com, alecflett, yurys+blink_chromium.org, abarth-chromium, Rik, kenneth.christiansen, loislo+blink_chromium.org, lushnikov+blink_chromium.org, kinuko, eustas+blink_chromium.org, darktears, Nate Chapin, vcarbune.chromium, jsbell, jsbell+bindings_chromium.org, feature-media-reviews_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, f(malita), dgrogan, Stephen Chennney
Visibility:
Public.

Description

Remove VTable-based binding integrity now that ScriptWrappable-based binding integrity is implemented. R=abarth@chromium.org BUG=239248 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=150465

Patch Set 1 #

Patch Set 2 : rebase, remove ImplementationLacksVTable attribute from template. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -822 lines) Patch
Source/bindings/scripts/CodeGeneratorV8.pm View 1 4 chunks +0 lines, -155 lines 0 comments Download
Source/bindings/scripts/IDLAttributes.txt View 2 chunks +0 lines, -2 lines 0 comments Download
Source/bindings/tests/results/V8Float64Array.cpp View 1 2 chunks +0 lines, -36 lines 0 comments Download
Source/bindings/tests/results/V8TestActiveDOMObject.cpp View 1 2 chunks +0 lines, -36 lines 0 comments Download
Source/bindings/tests/results/V8TestCustomNamedGetter.cpp View 1 2 chunks +0 lines, -36 lines 0 comments Download
Source/bindings/tests/results/V8TestEventConstructor.cpp View 1 2 chunks +0 lines, -36 lines 0 comments Download
Source/bindings/tests/results/V8TestEventTarget.cpp View 1 2 chunks +0 lines, -36 lines 0 comments Download
Source/bindings/tests/results/V8TestException.cpp View 1 2 chunks +0 lines, -36 lines 0 comments Download
Source/bindings/tests/results/V8TestInterface.cpp View 1 2 chunks +0 lines, -36 lines 0 comments Download
Source/bindings/tests/results/V8TestMediaQueryListListener.cpp View 1 2 chunks +0 lines, -36 lines 0 comments Download
Source/bindings/tests/results/V8TestNamedConstructor.cpp View 1 2 chunks +0 lines, -36 lines 0 comments Download
Source/bindings/tests/results/V8TestNode.cpp View 1 2 chunks +0 lines, -36 lines 0 comments Download
Source/bindings/tests/results/V8TestObject.cpp View 1 2 chunks +0 lines, -36 lines 0 comments Download
Source/bindings/tests/results/V8TestOverloadedConstructors.cpp View 1 2 chunks +0 lines, -36 lines 0 comments Download
Source/bindings/tests/results/V8TestSerializedScriptValueInterface.cpp View 1 2 chunks +0 lines, -36 lines 0 comments Download
Source/bindings/tests/results/V8TestTypedefs.cpp View 1 2 chunks +0 lines, -36 lines 0 comments Download
Source/core/css/CSS.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/core/css/CSSPrimitiveValue.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/css/CSSRule.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/css/CSSRuleList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/css/CSSStyleDeclaration.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/core/css/CSSValue.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/css/CSSValueList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/css/Counter.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/css/MediaList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/css/MediaQueryList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/css/RGBColor.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/css/Rect.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/css/StyleSheetList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/css/WebKitCSSFilterValue.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/css/WebKitCSSMixFunctionValue.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/css/WebKitCSSTransformValue.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/ClientRect.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/ClientRectList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/Clipboard.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/DOMCoreException.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/DOMError.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/DOMImplementation.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/DOMNamedFlowCollection.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/DOMStringList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/DOMStringMap.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/DataTransferItem.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/DataTransferItemList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/DocumentFragment.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/Element.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/Entity.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/Event.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/EventException.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/MessageChannel.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/MouseEvent.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/MutationObserver.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/MutationRecord.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/NamedNodeMap.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/NodeFilter.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/NodeIterator.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/NodeList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/Range.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/Text.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/Touch.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/TouchList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/dom/TreeWalker.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/features.gypi View 1 1 chunk +0 lines, -5 lines 0 comments Download
Source/core/fileapi/FileError.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/fileapi/FileException.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/fileapi/FileList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/DOMSettableTokenList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/DOMTokenList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/FormData.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/HTMLCollection.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/HTMLDialogElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/HTMLDivElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/HTMLDocument.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/HTMLElement.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/HTMLEmbedElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/HTMLImageElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/HTMLInputElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/HTMLSelectElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/HTMLSpanElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/HTMLUnknownElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/ImageData.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/MediaError.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/MediaKeyError.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/TextMetrics.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/TimeRanges.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/URL.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/ValidityState.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/canvas/ArrayBuffer.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/canvas/CanvasGradient.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/canvas/CanvasPattern.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/canvas/WebGLActiveInfo.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/canvas/WebGLShaderPrecisionFormat.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/ime/Composition.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/ime/InputMethodContext.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/shadow/HTMLContentElement.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/track/TextTrack.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/track/TextTrackCue.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/track/TextTrackCueList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/html/track/TextTrackRegionList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/inspector/InjectedScriptHost.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/inspector/InspectorFrontendHost.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/inspector/JavaScriptCallFrame.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/page/Crypto.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/page/DOMPoint.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/page/MemoryInfo.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/page/PagePopupController.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/page/SpeechInputResult.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/page/SpeechInputResultList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/scripts/templates/InternalRuntimeFlags.idl.tmpl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGAnimatedAngle.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGAnimatedBoolean.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGAnimatedEnumeration.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGAnimatedInteger.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGAnimatedLength.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGAnimatedLengthList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGAnimatedNumber.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGAnimatedNumberList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGAnimatedPreserveAspectRatio.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGAnimatedRect.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGAnimatedString.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGAnimatedTransformList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGColor.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGException.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGPaint.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGPathSeg.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGRenderingIntent.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGUnitTypes.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/svg/SVGZoomAndPan.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/testing/MallocStatistics.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/testing/TypeConversions.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/workers/WorkerLocation.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/xml/DOMParser.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/xml/XMLSerializer.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/xml/XPathEvaluator.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/xml/XPathException.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/xml/XPathExpression.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/xml/XPathNSResolver.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/xml/XPathResult.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/core/xml/XSLTProcessor.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/device_orientation/DeviceAcceleration.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/device_orientation/DeviceRotationRate.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/filesystem/DirectoryReader.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/filesystem/DirectoryReaderSync.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/filesystem/EntryArray.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/filesystem/EntryArraySync.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/filesystem/Metadata.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/gamepad/Gamepad.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/gamepad/GamepadList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/geolocation/Coordinates.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/geolocation/Geoposition.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/geolocation/PositionError.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/indexeddb/IDBFactory.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/indexeddb/IDBIndex.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/indexeddb/IDBKeyRange.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/indexeddb/IDBObjectStore.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/mediastream/RTCStatsReport.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/quota/StorageInfo.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/quota/StorageQuota.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/speech/SpeechGrammar.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/speech/SpeechGrammarList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/speech/SpeechRecognitionAlternative.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/speech/SpeechRecognitionResult.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/speech/SpeechRecognitionResultList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/webaudio/AudioBuffer.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/webaudio/AudioDestinationNode.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/webaudio/AudioListener.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/webaudio/AudioSourceNode.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/webaudio/WaveTable.idl View 1 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/webdatabase/SQLError.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/webdatabase/SQLException.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/webdatabase/SQLResultSet.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/webdatabase/SQLResultSetRowList.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/webdatabase/SQLTransaction.idl View 1 chunk +0 lines, -1 line 0 comments Download
Source/modules/webdatabase/SQLTransactionSync.idl View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Tom Sepez
Probably should wait a day or two before landing to make sure the new code ...
7 years, 7 months ago (2013-05-09 22:33:37 UTC) #1
abarth-chromium
LGTM! Glad you got the new system working.
7 years, 7 months ago (2013-05-09 22:47:03 UTC) #2
haraken
Fantastic clean-up.
7 years, 7 months ago (2013-05-09 22:48:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tsepez@chromium.org/15004016/4001
7 years, 7 months ago (2013-05-15 23:26:47 UTC) #4
commit-bot: I haz the power
7 years, 7 months ago (2013-05-16 00:38:05 UTC) #5
Message was sent while issue was closed. 
Change committed as 150465

Powered by Google App Engine
This is Rietveld 408576698